-
Notifications
You must be signed in to change notification settings - Fork 8
feat: full refactor #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
031b7bb
to
e5eed6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly minor stuff
e731377
to
118a6d8
Compare
@sierpinskid I agree, but this follows the convention of the other libraries, such as the javascript one. |
b3567be
to
85f6c49
Compare
7bb606f
to
56efc75
Compare
56efc75
to
85b3a6d
Compare
e8ab576
to
897af32
Compare
/// <summary> | ||
/// Partial update of an <see cref="Activity"/>. | ||
/// </summary> | ||
Task<ResponseBase> ActivityPartialUpdateAsync(string id = null, ForeignIdTime foreignIdTime = null, Dictionary<string, object> set = null, IEnumerable<string> unset = null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to add activity getters into client too.
It's a missing feature, later on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, how does that look like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks great, left a few small comments. Let's address them.
Also, good to review public method comments, didn't point all of them but there are wrong ones due to copy paste
b90d218
to
a41a176
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Draft, I may add a few things next week.