Fix error and pending states when editing a message #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
commented
May 27, 2025
Comment on lines
+21
to
+27
| guard isDeleted == false else { | ||
| return false | ||
| } | ||
|
|
||
| if isBounced { | ||
| return true | ||
| } |
There was a problem hiding this comment.
We have this duplicated from UIKit, so I copied the most recent version. The weird thing, is that we were not using this property at all. It most likely could be moved to the LLC in the future.
There was a problem hiding this comment.
Yeah, looks like an oversight. Would be nice to do so indeed.
SDK Size
|
|
laevandus
approved these changes
May 28, 2025
laevandus
deleted the
fix/error-indicator-not-shown-when-edit-message-fails
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
https://linear.app/stream/issue/IOS-846/homebase-error-indicator-not-shown-when-editing-message-fails
🎯 Goal
🧪 Manual Testing Notes
☑️ Contributor Checklist
docs-contentrepo