Add view factory methods for customising headers in GalleryView and VideoPlayerView #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laevandus
force-pushed
the
add/gallery-header-view-factory
branch
from
f8981aa to
362e904
Compare
laevandus
force-pushed
the
add/gallery-header-view-factory
branch
from
362e904 to
39d8e05
Compare
SDK Size
|
laevandus
changed the title
laevandus
force-pushed
the
add/gallery-header-view-factory
branch
from
39d8e05 to
4a9f6c0
Compare
| @@ -982,7 +982,7 @@ class ViewFactory_Tests: StreamChatTestCase { | |||
| ) | |||
|
|
|||
| // Then | |||
| XCTAssert(view is GalleryView) | |||
| XCTAssert(view is GalleryView<DefaultViewFactory>) | |||
There was a problem hiding this comment.
Should we also add tests to check the returned type of the new methods? Just to protect against breaking changes.
martinmitrevski
approved these changes
May 27, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves: IOS-880
🎯 Goal
GalleryViewandVideoPlayerView📝 Summary
GalleryHeaderViewinGalleryViewandVideoPlayerView🛠 Implementation
🧪 Manual Testing Notes
N/A
☑️ Contributor Checklist
docs-contentrepo