Skip to content

refactor(ui,core): remove deprecated code and cleanup #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 27, 2022
Merged

refactor(ui,core): remove deprecated code and cleanup #1221

merged 9 commits into from
Jun 27, 2022

Conversation

imtoori
Copy link
Contributor

@imtoori imtoori commented Jun 27, 2022

No description provided.

@imtoori imtoori force-pushed the refactor/prepare-for-v5 branch from 84f358c to d04cbfc Compare June 27, 2022 09:01
@codecov
Copy link

codecov bot commented Jun 27, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (v5@338f907). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head aa971e1 differs from pull request most recent head 8056eb9. Consider uploading reports for the commit 8056eb9 to get more accurate results

@@          Coverage Diff          @@
##             v5    #1221   +/-   ##
=====================================
  Coverage      ?   70.99%           
=====================================
  Files         ?      282           
  Lines         ?    23214           
  Branches      ?        0           
=====================================
  Hits          ?    16481           
  Misses        ?     6733           
  Partials      ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 338f907...8056eb9. Read the comment docs.

GroovinChip
GroovinChip suggested changes Jun 27, 2022
View reviewed changes
@imtoori imtoori requested a review from GroovinChip June 27, 2022 10:54
ayush221b
ayush221b suggested changes Jun 27, 2022
View reviewed changes
GroovinChip
GroovinChip approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@GroovinChip GroovinChip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtoori imtoori merged commit f49f055 into v5 Jun 27, 2022
@xsahil03x xsahil03x deleted the refactor/prepare-for-v5 branch May 1, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GroovinChip GroovinChip GroovinChip approved these changes

@ayush221b ayush221b ayush221b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imtoori @GroovinChip @ayush221b