Prevent cURL from adding Expect: 100-continue header to large requests

Author: Maciej Tarnowski

src/Handler/CurlRequestHandler.php

@@ -168,6 +168,11 @@ protected function setUpCurl(RequestInterface $request, $curlHandle)
             curl_setopt($curlHandle, CURLOPT_POSTFIELDS, (string) $request->getBody());
         }
 
+        if (!$request->hasHeader('expect') && $request->getBody()->getSize() > 0) {
+            // prevent cURL from adding `Expect: 100-continue` automatically
+            $headers['Expect'] = '';
+        }
+
         if ($request->getMethod() === self::METHOD_DELETE) {
             curl_setopt($curlHandle, CURLOPT_CUSTOMREQUEST, self::METHOD_DELETE);
             if ($request->getBody()->getSize() > 0) {

src/Version.php

@@ -8,5 +8,5 @@
  */
 class Version
 {
-    const VERSION = '1.0.0';
+    const VERSION = '1.1.0';
 }

tests/Unit/Exception/ExceptionFactoryTest.php

@@ -29,7 +29,11 @@ class ExceptionFactoryTest extends \PHPUnit_Framework_TestCase
     public function shouldInstantiateCorrectExceptionClass($code, $expectedClass, $expectedMessage)
     {
         $request = new Request('get', 'http://url.com', []);
-        $response = new Response($code, []);
+        if ($code < 100 || $code >= 600) {
+            $response = null;
+        } else {
+            $response = new Response($code, []);
+        }
         $message = 'error message';
         $handlerInfo = ['foo' => 'bar'];
         $exception = ExceptionFactory::exceptionFrom($code, $request, $message, $handlerInfo, '10', $response);

tests/Unit/Operation/CommandOperationTest.php

@@ -42,17 +42,6 @@ public function shouldThrowInvalidCommandDataExceptionDuringSetWithInvalidField(
         $this->systemUnderTest->set('fromField', uniqid('fromField', true));
     }
 
-    /**
-     * @test
-     * @expectedException \Getresponse\Sdk\Client\Exception\InvalidCommandDataException
-     * @expectedExceptionMessage Command Getresponse\Sdk\Client\Test\Unit\Operation\CommandOperationImplementation is missing required fields: email, campaign
-     */
-    public function shouldThrowInvalidCommandDataExceptionDuringGetBodyIfNotAllRequiredFieldsAreSet()
-    {
-        self::markTestSkipped('Do not check fields requirement');
-        $this->systemUnderTest->getBody();
-    }
-
     /**
      * @test
      * @expectedException \Getresponse\Sdk\Client\Exception\InvalidCommandDataException