Skip to content

Commit 758f8a2

Browse files
dpursehouseGerrit Code Review
authored andcommitted
Merge changes from topic 'fix-compiling'
* changes: Add new authenticate method from gitblit Switch to using Path instead of File for sitePaths Update hash for expected gitblit snapshot jar
2 parents cde89e6 + 8bf9759 commit 758f8a2

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

lib/BUCK

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ maven_jar(
1111
maven_jar(
1212
name = 'gitblit-jar',
1313
id = 'com.gitblit:gitblit:1.7.0-SNAPSHOT',
14-
sha1 = 'bf24e3a78f5421908326ec4e5a522a0bc7af3903',
14+
sha1 = 'd252a0ac519a2be2f652df8f4b342ea6953ae29a',
1515
license = 'Apache2.0',
1616
repository = GERRITFORGE,
1717
)

src/main/java/com/googlesource/gerrit/plugins/gitblit/GerritGitBlitContext.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ class GerritGitBlitContext extends GitblitContext {
6060

6161
void init(ServletContext context) {
6262
// Manually configure IRuntimeManager
63-
runtime.setBaseFolder(sitePaths.site_path);
63+
runtime.setBaseFolder(sitePaths.site_path.toFile());
6464
runtime.getStatus().servletContainer = context.getServerInfo();
6565
runtime.start();
6666

src/main/java/com/googlesource/gerrit/plugins/gitblit/app/GitBlitSettings.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public GitBlitSettings(final LocalDiskRepositoryManager repoManager,
5757
this.properties = new Properties();
5858
this.repoManager = repoManager;
5959
this.config = new GitBlitUrlsConfig(config);
60-
this.etcDir = sitePaths.etc_dir;
60+
this.etcDir = sitePaths.etc_dir.toFile();
6161
load();
6262
}
6363

@@ -77,8 +77,8 @@ private void load() throws IOException {
7777
try {
7878
properties = new Properties();
7979
properties.load(resin);
80-
properties.put("git.repositoriesFolder", repoManager.getBasePath()
81-
.getAbsolutePath());
80+
properties.put("git.repositoriesFolder",
81+
getBasePath().getAbsolutePath());
8282
properties.put("realm.userService",
8383
GerritToGitBlitUserService.class.getName());
8484
if (properties.get("web.otherUrls") != null) {
@@ -112,7 +112,7 @@ private InputStream openPropertiesFile() {
112112
}
113113

114114
public File getBasePath() {
115-
return repoManager.getBasePath();
115+
return repoManager.getBasePath().toFile();
116116
}
117117

118118
@Override

src/main/java/com/googlesource/gerrit/plugins/gitblit/auth/GerritToGitBlitUserService.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,11 @@ public UserModel authenticate(HttpServletRequest httpRequest) {
153153
}
154154
}
155155

156+
@Override
157+
public UserModel authenticate(String username) {
158+
return null;
159+
}
160+
156161
@Override
157162
public UserModel authenticate(String username, SshKey key) {
158163
return null;

0 commit comments

Comments
 (0)