Skip to content

Commit 5d95ba8

Browse files
gavinmakLUCI
authored andcommitted
progress: Make end() idempotent
This fixes the double "done" text on successful interleaved sync. Bug: 421935613 Change-Id: I4f01418cb0340129a8f0a2a5835f7e3fa6a6b119 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/487081 Reviewed-by: Scott Lee <ddoman@google.com> Tested-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com>
1 parent 82d500e commit 5d95ba8

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

progress.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ def __init__(
101101
self._units = units
102102
self._elide = elide and _TTY
103103
self._quiet = quiet
104+
self._ended = False
104105

105106
# Only show the active jobs section if we run more than one in parallel.
106107
self._show_jobs = False
@@ -211,6 +212,10 @@ def display_message(self, msg):
211212
self.update(inc=0)
212213

213214
def end(self):
215+
if self._ended:
216+
return
217+
self._ended = True
218+
214219
self._update_event.set()
215220
if not _TTY or IsTraceToStderr() or self._quiet:
216221
return

0 commit comments

Comments
 (0)