Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Peertube support #244

Closed
1 of 4 tasks
RasheedAZ opened this issue May 11, 2023 · 6 comments · Fixed by #245 · May be fixed by #253
Closed
1 of 4 tasks

[Request]: Peertube support #244

RasheedAZ opened this issue May 11, 2023 · 6 comments · Fixed by #245 · May be fixed by #253
Labels
enhancement New feature or request

Comments

@RasheedAZ
Copy link

Describe the request

When a Mastodon post has a video attached to it, Tuba can play it if the user clicks on the video. However, for video uploads from Peertube accounts, only a link to the video page is shown which when clicked opens a browser window!

Is it possible to show a Peertube video (just like a Mastodon video) instead of a link to the video page?

There appears to be currently no working desktop client for following, commenting on and watching Peertube videos. There's Cuttlefish but it appears to be abandoned.

Implementation Details

  • This should be an option in settings.
  • This should be only available to some fediverse backends. (Include which ones on the above field).
  • This is client-only (and shouldn't sync with the instance).
  • This follows the GNOME HIG.
@RasheedAZ RasheedAZ added the enhancement New feature or request label May 11, 2023
@GeopJr
Copy link
Owner

GeopJr commented May 12, 2023

Thanks for the suggestion!

It will be done on #245 but since I don't really use peertube regularly, I might have missed special cases. Could you give it a try on accounts you usually watch?

You can either build it yourself or download one of the flatpak or snap artifacts when they are done https://github.com/GeopJr/Tuba/actions/runs/4956237749?pr=245

@GeopJr
Copy link
Owner

GeopJr commented May 13, 2023

Merged! If you notice anything, let me know!

@RasheedAZ
Copy link
Author

RasheedAZ commented May 15, 2023

Thanks. I managed to install the flatpak build and it works mostly. The videos appear in the cards, instead of only links and they are playable.

However, clicking the play button at the centre of the video does nothing - I have to click the small play button at the bottom left.

Also, it selects the 360p version instead of 720p or 1080p even though my connection is good.

The video duration (bottom left) shows as -0:05 and runs until -0:01 although the runtime (bottom right) appears to work correctly. See attached image.

Oh yes and the sound is not working.

Screenshot from 2023-05-15 23-50-32
Screenshot from 2023-05-15 23-41-41

@GeopJr
Copy link
Owner

GeopJr commented May 15, 2023

However, clicking the play button at the centre of the video does nothing - I have to click the small play button at the bottom left.

Gtk issue #205

Also, it selects the 360p version instead of 720p or 1080p even though my connection is good.

As the PR mentions, I've locked it to 720p, 480p and 360p (or the first result if none of these are available) because anything higher had an impact on performance. The instance the linux experiment's video is on reports that it has 1080p, 360p and 144p, so 360p was selected.

The video duration (bottom left) shows as -0:05 and runs until -0:01 although the runtime (bottom right) appears to work correctly. See attached image.

I'll see what I can do about that, I mostly followed Cuttlefish's implementation

Oh yes and the sound is not working.

Can't reproduce.
Does it play if you open the volume slider at the bottom right and changing it?
Do other non-peertube videos have audio?
Did you change the flatpak permissions to remove the pulseaudio permission?

@RasheedAZ
Copy link
Author

Sound started working after opening the volume slider and changing it. Continued working upon successive reopens. Thanks.

No I hadn't changed the flatpak permissions.

Also, after clicking the back button, the sound of the video continued playing even when a different video was playing. However, after restarting the Tuba, I was not able to reproduce this either.

@GeopJr
Copy link
Owner

GeopJr commented May 19, 2023

I've disabled PeerTube support for now as streaming is a bit tricky. Cuttlefish got away with it because it's locked to the Blender instance which offers the files directly instead of just streaming (which most instances don't). I'll let you know when I re-enable it (after ironing out all issues)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants