Skip to content

Commit 05674f5

Browse files
committed
Fix response type issues
Some endpoints respond with only a string instead of JSON. This commit skips parsing those responses and returns the response text as a string.
1 parent 391609e commit 05674f5

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

src/Forge.js

+6-5
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ class Forge extends ForgeRequest {
204204
activate: (serverId, siteId, certId) =>
205205
this.post(
206206
`/servers/${serverId}/sites/${siteId}/certificates/${certId}/activate`,
207+
{parseResponse: false},
207208
),
208209
delete: (serverId, siteId, certId) =>
209210
this.delete(
@@ -287,7 +288,7 @@ class Forge extends ForgeRequest {
287288
disable: (serverId, siteId) =>
288289
this.delete(`/servers/${serverId}/sites/${siteId}/deployment`),
289290
getScript: (serverId, siteId) =>
290-
this.get(`/servers/${serverId}/sites/${siteId}/deployment/script`),
291+
this.get(`/servers/${serverId}/sites/${siteId}/deployment/script`, {parseResponse: false}),
291292
updateScript: (serverId, siteId, payload) =>
292293
this.put(
293294
`/servers/${serverId}/sites/${siteId}/deployment/script`,
@@ -320,13 +321,13 @@ class Forge extends ForgeRequest {
320321
get config() {
321322
return {
322323
getNginx: (serverId, siteId) =>
323-
this.get(`/servers/${serverId}/sites/${siteId}/nginx`),
324+
this.get(`/servers/${serverId}/sites/${siteId}/nginx`, {parseResponse: false}),
324325
updateNginx: (serverId, siteId, payload) =>
325-
this.put(`/servers/${serverId}/sites/${siteId}/nginx`, payload),
326+
this.put(`/servers/${serverId}/sites/${siteId}/nginx`, payload, {parseResponse: false}),
326327
getEnv: (serverId, siteId) =>
327-
this.get(`/servers/${serverId}/sites/${siteId}/env`),
328+
this.get(`/servers/${serverId}/sites/${siteId}/env`, {parseResponse: false}),
328329
updateEnv: (serverId, siteId, payload) =>
329-
this.put(`/servers/${serverId}/sites/${siteId}/env`, payload),
330+
this.put(`/servers/${serverId}/sites/${siteId}/env`, payload, {parseResponse: false}),
330331
};
331332
}
332333

src/core/ForgeRequest.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class ForgeRequest {
2121
if (options.parseResponse !== false && res.status !== 204)
2222
return res.json();
2323

24-
return undefined;
24+
return res.text();
2525
}
2626

2727
get(endpoint, options = {}) {

0 commit comments

Comments
 (0)