-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PyVista for 3D plotting in Python #29
Conversation
AppVeyor build seems hung on the twine upload? |
Wow, thank you so much for the effort you already put into this project! I haven't looked into the details yet, but your plotting routines look very intriguing indeed. |
@banesullivan : Thanks for this astonishing PR!
I hope you are OK with this. We don't want to drop so much supported version for a visualization routine. At least at the moment. What do you think? Thanks again for your work and the nice pyvista package! Cheers, Sebastian |
Hi @MuellerSeb, thanks for all the feedback! I'll get back to this PR soon and clean it up so PyVista is simply added on top as an extra and rebase all these commits to leave the CI integration untouched. Overall, I think what you propose is perfect |
@LSchueler and @MuellerSeb, I just rebased all of the commits and made the desired changes! I also updated the description in the first post (^^^), take a look and let me know what you think! Notes:
|
Also, I added tests for both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort! I like the implementation. Only the new requirements.txt is making trouble on travis.
Cheers,
Sebastian
Also don't forget to add yourself to the AUTHORS.md under Contributors! ;-) |
You don't have access to our PyPI password, that is why both, travis and appveyor, are hanging on twine and the CI fails. So this is no problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are done now! Thanks for the enchanting feature!
Looking good to me! I look forward to using this package - I've been searching for a good kriging toolbox and I think I've finally found it! Having the ties to PyVista hopefully might bring in a few other users if not just myself! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thanks for your work from my side!
I just added some very minor things I'd like to see changed before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the changes!
Todo
This PR uses PyVista for creating VTK datasets in Python for immediate plotting. The
pyevtk
export code is still present to allow users to save VTK files in any Python environment. PyVista is a heavy dependency so these additions are implemented as optional features.When complete, this will need to use "Squash and Merge"
PyVista allows you to create VTK data objects in memory really easily instead of saving them out to static files. Why might you want VTK/PyVista meshes in Python? So you can skip saving VTK files and visualize the datasets right in Python! Check out this example:
Notes
I added a new method:
to_pyvista()
.