Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] dimensionality check for CovModel #86

Closed
MuellerSeb opened this issue May 2, 2020 · 1 comment · Fixed by #109
Closed

[Enhancement] dimensionality check for CovModel #86

MuellerSeb opened this issue May 2, 2020 · 1 comment · Fixed by #109
Assignees
@MuellerSeb
Labels
enhancement New feature or request Refactoring Code-Refactoring needed here
Milestone
1.3

Comments

@MuellerSeb
Copy link
Member

Since some CovModels are only valid up to a certain dimensionality (eg. Linear only in 1D, Circular only in nD for n<3), we should provide a dim_valid routine in the CovModel class, that could also be overridden by the user.

As default, we should return True since many models are valid in arbitrary dimensions.
@MuellerSeb MuellerSeb added enhancement New feature or request Refactoring Code-Refactoring needed here labels May 2, 2020
@MuellerSeb MuellerSeb added this to the 1.3 milestone May 2, 2020
@MuellerSeb MuellerSeb self-assigned this May 2, 2020
@MuellerSeb
Copy link
Member Author

A warning should pop up. An Error would be to harsh, since users should be allowed to make their own mistakes.

@MuellerSeb MuellerSeb linked a pull request Nov 14, 2020 that will close this issue
CovModel: Update and Refactoring #109
Merged
@MuellerSeb MuellerSeb mentioned this issue Nov 14, 2020
Merged
@MuellerSeb MuellerSeb mentioned this issue Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MuellerSeb MuellerSeb

Labels
enhancement New feature or request Refactoring Code-Refactoring needed here
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

CovModel: Update and Refactoring GeoStat-Framework/GSTools
1 participant
@MuellerSeb