Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] add TUI syntax highlighting to the glob editor #443

Closed
genivia-inc opened this issue Nov 19, 2024 · 1 comment
Closed

[FR] add TUI syntax highlighting to the glob editor #443

genivia-inc opened this issue Nov 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@genivia-inc
Copy link
Member

Add syntax highlighting to the TUI glob editor. Globs are edited in the TUI by pressing ALT-g (or Option-g with MacOS.)

For example, editing the C++ globs that are initially populated with ug -Q -tcpp should look like this:
image

Right now in v7.0, the glob editor syntax highlighting isn't showing up correctly, because the TUI is still in regex syntax highlighting mode.

Also, when viewing the help page with F1 or CTRL-Z, pressing ALT-g should jump right into the glob edit line instead of showing a message that globs can't be edited when viewing the help page.

@genivia-inc genivia-inc added the enhancement New feature or request label Nov 19, 2024
@genivia-inc
Copy link
Member Author

genivia-inc commented Nov 20, 2024

As I am aggressively experimenting with the TUI, I found a little glitch when a single directory is specified as the search target. When we Tab into it in the TUI, the listing is empty because a recursive search is not performed inside that directory. This happens because the target is a directory that we initially search at one level, not recursively. But when we Tab into it, then the TUI should temporarily enable recursive searching until we Shift-Tab out of it. This will be fixed as well.

In addition, the boolean search regex highlighting in the TUI isn't 100% satisfactory and can be improved.

genivia-inc added a commit that referenced this issue Nov 22, 2024
add new features #442 and #443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant