Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update np.array() calls on three separate arrays to single dask.compute() call #1

Open
jni opened this issue Nov 30, 2021 · 2 comments

Comments

@jni
Copy link

jni commented Nov 30, 2021

In the notebook/blog post, there is a cell where three different arrays (rows, cols, data) are created that potentially share tasks in the task graph. This could be sped up by using a single compute() call with all three arrays. Cell 25 here:

Screen Shot 2021-11-30 at 6 51 32 pm

The blog post should be updated not just with the "better" way, but with a comment showing the old way and explaining why the new way is better. Perfect real-world teachable moment! 😊

@GenevieveBuckley
Copy link
Owner

Yeah, I'm not going to be able to get around to this before I start my new job 😢

I agree with all of this. We should definitely do it ...sometime

@jni
Copy link
Author

jni commented Dec 12, 2021

We should definitely do it ...sometime

This is just par for the course in FOSS, I have learned to let it wash over me... 😊 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants