CI: Add GMT's bin to PATH for GMT dev tests #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
weiji14
reviewed
Feb 12, 2021
Comment on lines
+121
to
127
| - name: Add GMT's bin to PATH (Linux/macOS) | ||
| run: echo ${GITHUB_WORKSPACE}/gmt-install-dir/bin >> $GITHUB_PATH | ||
| if: runner.os != 'Windows' | ||
|
|
||
| # Run the tests | ||
| - name: Test with pytest (Linux/macOS) | ||
| run: make test PYTEST_EXTRA="-r P" |
There was a problem hiding this comment.
Can we just add it inline here?
Suggested change
| - name: Add GMT's bin to PATH (Linux/macOS) | |
| run: echo ${GITHUB_WORKSPACE}/gmt-install-dir/bin >> $GITHUB_PATH | |
| if: runner.os != 'Windows' | |
| # Run the tests | |
| - name: Test with pytest (Linux/macOS) | |
| run: make test PYTEST_EXTRA="-r P" | |
| # Run the tests | |
| - name: Test with pytest (Linux/macOS) | |
| run: | | |
| echo ${GITHUB_WORKSPACE}/gmt-install-dir/bin >> $GITHUB_PATH # Add GMT's bin to PATH | |
| make test PYTEST_EXTRA="-r P" |
There was a problem hiding this comment.
I don't think it will work.
Prepends a directory to the system PATH variable and makes it available to all subsequent actions in the current job; the currently running action cannot access the updated path variable.
There was a problem hiding this comment.
Ah, that's annoying, nevermind then.
weiji14
approved these changes
Feb 12, 2021
Comment on lines
+121
to
127
| - name: Add GMT's bin to PATH (Linux/macOS) | ||
| run: echo ${GITHUB_WORKSPACE}/gmt-install-dir/bin >> $GITHUB_PATH | ||
| if: runner.os != 'Windows' | ||
|
|
||
| # Run the tests | ||
| - name: Test with pytest (Linux/macOS) | ||
| run: make test PYTEST_EXTRA="-r P" |
There was a problem hiding this comment.
Ah, that's annoying, nevermind then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See #874 for context.
Fixes #874.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version