Skip to content

NEP29: Test PyGMT on NumPy 1.25 #2581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2023
Merged

NEP29: Test PyGMT on NumPy 1.25 #2581

merged 1 commit into from
Jun 21, 2023

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Jun 20, 2023

Description of proposed changes

Bumps numpy from 1.24.3 to 1.25.0. NumPy 1.25.0 was released on 18 Jun 2023.

This is in line with PyGMT's policy on NEP29 at https://www.pygmt.org/v0.9.0/maintenance.html#dependencies-policy, xref #1074.

Note that the branch protection rules at GenericMappingTools/pygmt/settings/branches will need to be changed to use Python 3.11/Numpy 1.25 instead of Python 3.11/Numpy 1.25 before this Pull Request is merged.

Supersedes #2256

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label Jun 20, 2023
@weiji14 weiji14 added this to the 0.10.0 milestone Jun 20, 2023
@weiji14 weiji14 self-assigned this Jun 20, 2023
@weiji14 weiji14 marked this pull request as ready for review June 20, 2023 23:26
@weiji14
Copy link
Member Author

weiji14 commented Jun 20, 2023

Cool, tests pass on Numpy 1.25.0 without any warnings (see https://github.com/GenericMappingTools/pygmt/actions/runs/5328296663/jobs/9652751468?pr=2581#step:9:719).

By the way, we should bump up the minimum version of Numpy from 1.21 to 1.22 on 23 Jun 2023 according to https://numpy.org/neps/nep-0029-deprecation_policy.html#drop-schedule. Can do this in a separate PR.

@weiji14 weiji14 merged commit a5acdfa into main Jun 21, 2023
@weiji14 weiji14 deleted the nep29/numpy-1.25 branch June 21, 2023 00:12
@seisman
Copy link
Member

seisman commented Jun 26, 2023

By the way, we should bump up the minimum version of Numpy from 1.21 to 1.22 on 23 Jun 2023 according to https://numpy.org/neps/nep-0029-deprecation_policy.html#drop-schedule. Can do this in a separate PR.

@weiji14 It's time to do it!

@weiji14
Copy link
Member Author

weiji14 commented Jun 26, 2023

By the way, we should bump up the minimum version of Numpy from 1.21 to 1.22 on 23 Jun 2023 according to https://numpy.org/neps/nep-0029-deprecation_policy.html#drop-schedule. Can do this in a separate PR.

@weiji14 It's time to do it!

Ok, I'll open a PR for that 😄 Edit: done at #2586.

@seisman seisman mentioned this pull request Sep 17, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants