Skip to content

Update xfail velo tests for GMT 6.3 #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2021
Merged

Update xfail velo tests for GMT 6.3 #1657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ba12f3
Update xfail velo tests for GMT 6.3
Dec 13, 2021
3958f0d
Revert change to pen specs
Dec 13, 2021
cc1b138
Merge branch 'main' into update-velo-tests
Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pygmt/tests/baseline/test_velo_numpy_array_numeric_only.png.dvc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
outs:
- md5: 64e45d586112fc131090cfac2c104b63
size: 45483
- md5: 852dba2075122641e3785603207f9b88
size: 44362
path: test_velo_numpy_array_numeric_only.png
4 changes: 2 additions & 2 deletions pygmt/tests/baseline/test_velo_pandas_dataframe.png.dvc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
outs:
- md5: 60dff1a72e6d984f095fb4973cecaec7
size: 42430
- md5: 136a1b34e8ad58de070a83ed3941276e
size: 42906
path: test_velo_pandas_dataframe.png
8 changes: 0 additions & 8 deletions pygmt/tests/test_velo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ def fixture_dataframe():
)


@pytest.mark.xfail(
condition=gmt_version > Version("6.2.0"),
reason="Upstream bug fixed by https://github.com/GenericMappingTools/gmt/pull/5360.",
)
@pytest.mark.mpl_image_compare
def test_velo_numpy_array_numeric_only(dataframe):
"""
Expand Down Expand Up @@ -71,10 +67,6 @@ def test_velo_without_spec(dataframe):
fig.velo(data=dataframe)


@pytest.mark.xfail(
condition=gmt_version > Version("6.2.0"),
reason="Upstream bug fixed by https://github.com/GenericMappingTools/gmt/pull/5360.",
)
@pytest.mark.mpl_image_compare
def test_velo_pandas_dataframe(dataframe):
"""
Expand Down