Add MaunaLoa_CO2.txt to cached files #1615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiji14
added
maintenance
weiji14
reviewed
Nov 7, 2021
pygmt/helpers/testing.py
Outdated
| @@ -174,6 +174,7 @@ def download_test_data(): | |||
| "@hotspots.txt", | |||
| "@ridge.txt", | |||
| "@mars370d.txt", | |||
| "@MaunaLoa_CO2.txt", | |||
There was a problem hiding this comment.
A few things:
- Move this up to L172 to be after
@EGM96_to_36.txtso that we're sorting by ASCIIbetical order (capital letters before small letters). Maybe move up@Table_5_11.txtwhile you're at it. - Add an
@and comma to L170 to fix the problem mentioned at Windows CI tests regularly failing due to issues with cached remote files for sph2grd #1602 (comment). Specifically, change"S90W180.earth_age_05m_g.nc"to"@S90W180.earth_age_05m_g.nc", - Trigger the cache download!
seisman
approved these changes
Nov 8, 2021
michaelgrund
approved these changes
Nov 8, 2021
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
* Add MaunaLoa_CO2.txt * Reorder cached file list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed by @weiji14 at this comment, this pull request adds the MaunaLoa_CO2.txt remote file to the cached files for testing.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version