Use pip install as workaround when make install doesn't work #1585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue with `pip=21.3`, inspired by commit from zarr-developers/zarr-python@7ee2ded.
So that Windows users without `make` can install an editable version of PyGMT locally.
weiji14
added
maintenance
|
Is your plan to revert back to make install after a bug fix comes out or keep this long-term? |
I think keep this long term, since editable installs don't make sense on the cloud anyway. |
maxrjones
approved these changes
Oct 20, 2021
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…MappingTools#1585) * Don't use editable install for vercel build Fixes issue with `pip=21.3`, inspired by commit from zarr-developers/zarr-python@7ee2ded. * Mention how Windows users can install PyGMT in editable mode So that Windows users without `make` can install an editable version of PyGMT locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Since a bugfix for
pip=21.3isn't out yet, this is a workaround inspired by zarr-developers/zarr-python@7ee2ded to fix the distutils error on Vercel builds:Also took the liberty to mention that
make installis replaceable withpip install --no-deps -e .on Windows.Fixes #1575 (comment) and #1471 (comment).
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version