Skip to content

Universal virtualfile_from_data function to replace virtualfile_from_grid/matrix/vectors #949

Closed
@weiji14

Description

@weiji14

Description of the desired feature

As a user, I'd like to be able to pass in any type of data into a PyGMT function in a consistent way, be it:

Current state

We have a not so nice if... then block that currently handles the Input/Output (I/O) of data into PyGMT. This results in an incosistent API. E.g. fig.plot requires numpy.ndarray inputs while pygmt.grdtrack requires pandas.DataFrame inputs. Users (e.g. at https://forum.generic-mapping-tools.org/t/pygmt-plot-errorbars) should not have to figure out which PyData format is needed.

Originally posted by @weiji14 in #946 (comment)

I was going to create a virtualfile_from_data() function to replace this common block of code in our functions:

    with Session() as lib:
        # Choose how data will be passed in to the module
        if kind == "file":
            file_context = dummy_context(data)
        elif kind == "matrix":
            file_context = lib.virtualfile_from_matrix(data)
        elif kind == "vectors":
            file_context = lib.virtualfile_from_vectors(...)

Future state

The idea is to have a virtualfile_from_data() function (open to other names) that wraps around the current dummy_context/virtualfile_from_matrix/virtualfile_from_vectors/virtualfile_from_grid functions, which makes things easier for both end users and developers wrapping new modules that handle data.

This universal virtualfile_from_data() may pave the way to support more data inputs in the future:

TLDR: Be able to throw any sort of data into a PyGMT function and it will 'just work'.

Note that xarray is in the process of refactoring to an APIv2 (see pydata/xarray#4309) that has some similarities with this issue. They call it a 'Flexible Backend", a sort of extensible 'plugin'-type system which is a bit more future proofed to allow for new data formats (e.g. GPU backed arrays) coming in.

Are you willing to help implement and maintain this feature? Yes, but help is very welcome

Update: The virtualfile_from_data function has been created in #961. Feel free people to refactor some of the plotting/data processing functions in https://github.com/GenericMappingTools/pygmt/tree/master/pygmt/src to use this (e.g. contour, meca, etc).

TODO:

Metadata

Metadata

Assignees

Labels

enhancementImproving an existing featurehelp wantedHelping hands are appreciated

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions