Replace IDrivelutionLogger with GeneralTracer for consistent logging

Copilot · JusterZhu · Copilot · commit cfc28c7c145c · 2026-02-11T16:42:47.000Z
Co-authored-by: JusterZhu &lt;11714536+JusterZhu@users.noreply.github.com&gt;
diff --git a/src/c#/DrivelutionTest/Core/DriverUpdaterFactoryTests.cs b/src/c#/DrivelutionTest/Core/DriverUpdaterFactoryTests.cs
@@ -1,7 +1,6 @@
 using GeneralUpdate.Drivelution.Core;
 using GeneralUpdate.Drivelution.Abstractions;
 using GeneralUpdate.Drivelution.Abstractions.Configuration;
-using GeneralUpdate.Drivelution.Abstractions.Events;
 
 namespace DrivelutionTest.Core;
 
@@ -25,23 +24,6 @@ public void Create_WithoutParameters_ReturnsNonNullInstance()
         Assert.IsAssignableFrom<IGeneralDrivelution>(updater);
     }
 
-    /// <summary>
-    /// Tests that Create method accepts custom logger.
-    /// </summary>
-    [Fact]
-    public void Create_WithCustomLogger_ReturnsInstance()
-    {
-        // Arrange
-        var logger = new DrivelutionLogger();
-
-        // Act
-        var updater = DrivelutionFactory.Create(logger);
-
-        // Assert
-        Assert.NotNull(updater);
-        Assert.IsAssignableFrom<IGeneralDrivelution>(updater);
-    }
-
     /// <summary>
     /// Tests that Create method accepts custom options.
     /// </summary>
@@ -55,7 +37,7 @@ public void Create_WithCustomOptions_ReturnsInstance()
         };
 
         // Act
-        var updater = DrivelutionFactory.Create(null, options);
+        var updater = DrivelutionFactory.Create(options);
 
         // Assert
         Assert.NotNull(updater);
@@ -93,7 +75,7 @@ public void IsPlatformSupported_ReturnsBooleanValue()
     /// Tests that CreateValidator returns a non-null instance.
     /// </summary>
     [Fact]
-    public void CreateValidator_WithoutLogger_ReturnsNonNullInstance()
+    public void CreateValidator_WithoutParameters_ReturnsNonNullInstance()
     {
         // Skip on MacOS and Unknown platforms
         var platform = DrivelutionFactory.GetCurrentPlatform();
@@ -114,7 +96,7 @@ public void CreateValidator_WithoutLogger_ReturnsNonNullInstance()
     /// Tests that CreateBackup returns a non-null instance.
     /// </summary>
     [Fact]
-    public void CreateBackup_WithoutLogger_ReturnsNonNullInstance()
+    public void CreateBackup_WithoutParameters_ReturnsNonNullInstance()
     {
         // Skip on MacOS and Unknown platforms
         var platform = DrivelutionFactory.GetCurrentPlatform();
@@ -131,52 +113,6 @@ public void CreateBackup_WithoutLogger_ReturnsNonNullInstance()
         Assert.IsAssignableFrom<IDriverBackup>(backup);
     }
 
-    /// <summary>
-    /// Tests that CreateValidator with custom logger works correctly.
-    /// </summary>
-    [Fact]
-    public void CreateValidator_WithCustomLogger_ReturnsInstance()
-    {
-        // Skip on MacOS and Unknown platforms
-        var platform = DrivelutionFactory.GetCurrentPlatform();
-        if (platform == "MacOS" || platform == "Unknown")
-        {
-            return;
-        }
-
-        // Arrange
-        var logger = new DrivelutionLogger();
-
-        // Act
-        var validator = DrivelutionFactory.CreateValidator(logger);
-
-        // Assert
-        Assert.NotNull(validator);
-    }
-
-    /// <summary>
-    /// Tests that CreateBackup with custom logger works correctly.
-    /// </summary>
-    [Fact]
-    public void CreateBackup_WithCustomLogger_ReturnsInstance()
-    {
-        // Skip on MacOS and Unknown platforms
-        var platform = DrivelutionFactory.GetCurrentPlatform();
-        if (platform == "MacOS" || platform == "Unknown")
-        {
-            return;
-        }
-
-        // Arrange
-        var logger = new DrivelutionLogger();
-
-        // Act
-        var backup = DrivelutionFactory.CreateBackup(logger);
-
-        // Assert
-        Assert.NotNull(backup);
-    }
-
     /// <summary>
     /// Tests that Create throws PlatformNotSupportedException on unsupported platforms.
     /// This test documents expected behavior but cannot be easily tested on supported platforms.
diff --git a/src/c#/DrivelutionTest/GeneralDrivelutionTests.cs b/src/c#/DrivelutionTest/GeneralDrivelutionTests.cs
@@ -1,7 +1,6 @@
 using GeneralUpdate.Drivelution;
 using GeneralUpdate.Drivelution.Abstractions.Models;
 using GeneralUpdate.Drivelution.Abstractions.Configuration;
-using GeneralUpdate.Drivelution.Abstractions.Events;
 
 namespace DrivelutionTest;
 
@@ -43,42 +42,6 @@ public void Create_WithOptions_ReturnsNonNullInstance()
         Assert.NotNull(updater);
     }
 
-    /// <summary>
-    /// Tests that Create method with custom logger returns a non-null instance.
-    /// </summary>
-    [Fact]
-    public void Create_WithCustomLogger_ReturnsNonNullInstance()
-    {
-        // Arrange
-        var logger = new DrivelutionLogger();
-
-        // Act
-        var updater = GeneralDrivelution.Create(logger);
-
-        // Assert
-        Assert.NotNull(updater);
-    }
-
-    /// <summary>
-    /// Tests that Create method with custom logger and options returns instance.
-    /// </summary>
-    [Fact]
-    public void Create_WithCustomLoggerAndOptions_ReturnsInstance()
-    {
-        // Arrange
-        var logger = new DrivelutionLogger();
-        var options = new DrivelutionOptions
-        {
-            DefaultBackupPath = "./backups"
-        };
-
-        // Act
-        var updater = GeneralDrivelution.Create(logger, options);
-
-        // Assert
-        Assert.NotNull(updater);
-    }
-
     /// <summary>
     /// Tests that GetPlatformInfo returns valid platform information.
     /// </summary>
diff --git a/src/c#/GeneralUpdate.Drivelution/Core/DriverUpdaterFactory.cs b/src/c#/GeneralUpdate.Drivelution/Core/DriverUpdaterFactory.cs
@@ -2,7 +2,6 @@
 using GeneralUpdate.Common.Shared;
 using GeneralUpdate.Drivelution.Abstractions;
 using GeneralUpdate.Drivelution.Abstractions.Configuration;
-using GeneralUpdate.Drivelution.Abstractions.Events;
 using GeneralUpdate.Drivelution.Windows.Implementation;
 using GeneralUpdate.Drivelution.Linux.Implementation;
 using GeneralUpdate.Drivelution.MacOS.Implementation;
@@ -19,12 +18,10 @@ public static class DrivelutionFactory
     /// 创建适合当前平台的驱动更新器
     /// Creates a driver updater suitable for the current platform
     /// </summary>
-    /// <param name="logger">日志记录器（已废弃，内部使用GeneralTracer）/ Logger (deprecated, uses GeneralTracer internally)</param>
     /// <param name="options">配置选项（可选）/ Configuration options (optional)</param>
     /// <returns>平台特定的驱动更新器实现 / Platform-specific driver updater implementation</returns>
     /// <exception cref="PlatformNotSupportedException">当前平台不支持时抛出 / Thrown when current platform is not supported</exception>
-    [Obsolete("Logger parameter is deprecated and will be ignored. The implementation now uses GeneralTracer for logging. Call Create(null, options) or omit the logger parameter.", false)]
-    public static IGeneralDrivelution Create(IDrivelutionLogger? logger = null, DrivelutionOptions? options = null)
+    public static IGeneralDrivelution Create(DrivelutionOptions? options = null)
     {
         // Detect platform and create appropriate implementation
         if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
@@ -63,10 +60,8 @@ public static IGeneralDrivelution Create(IDrivelutionLogger? logger = null, Driv
     /// 创建适合当前平台的驱动验证器
     /// Creates a driver validator suitable for the current platform
     /// </summary>
-    /// <param name="logger">日志记录器（已废弃，内部使用GeneralTracer）/ Logger (deprecated, uses GeneralTracer internally)</param>
     /// <returns>平台特定的驱动验证器实现 / Platform-specific driver validator implementation</returns>
-    [Obsolete("Logger parameter is deprecated and will be ignored. The implementation now uses GeneralTracer for logging. Call CreateValidator() without parameters.", false)]
-    public static IDriverValidator CreateValidator(IDrivelutionLogger? logger = null)
+    public static IDriverValidator CreateValidator()
     {
         if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
         {
@@ -90,10 +85,8 @@ public static IDriverValidator CreateValidator(IDrivelutionLogger? logger = null
     /// 创建适合当前平台的驱动备份管理器
     /// Creates a driver backup manager suitable for the current platform
     /// </summary>
-    /// <param name="logger">日志记录器（已废弃，内部使用GeneralTracer）/ Logger (deprecated, uses GeneralTracer internally)</param>
     /// <returns>平台特定的驱动备份实现 / Platform-specific driver backup implementation</returns>
-    [Obsolete("Logger parameter is deprecated and will be ignored. The implementation now uses GeneralTracer for logging. Call CreateBackup() without parameters.", false)]
-    public static IDriverBackup CreateBackup(IDrivelutionLogger? logger = null)
+    public static IDriverBackup CreateBackup()
     {
         if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
         {
@@ -141,13 +134,4 @@ public static bool IsPlatformSupported()
                RuntimeInformation.IsOSPlatform(OSPlatform.Linux);
         // MacOS is planned but not yet implemented
     }
-
-    /// <summary>
-    /// 创建默认日志记录器
-    /// Creates a default logger
-    /// </summary>
-    private static IDrivelutionLogger CreateDefaultLogger(DrivelutionOptions? options = null)
-    {
-        return Logging.LoggerConfigurator.ConfigureLogger(options);
-    }
 }
diff --git a/src/c#/GeneralUpdate.Drivelution/GeneralDrivelution.cs b/src/c#/GeneralUpdate.Drivelution/GeneralDrivelution.cs
@@ -1,8 +1,6 @@
 using GeneralUpdate.Drivelution.Abstractions;
 using GeneralUpdate.Drivelution.Abstractions.Configuration;
-using GeneralUpdate.Drivelution.Abstractions.Events;
 using GeneralUpdate.Drivelution.Abstractions.Models;
-using GeneralUpdate.Drivelution.Core.Logging;
 using GeneralUpdate.Drivelution.Core.Utilities;
 
 namespace GeneralUpdate.Drivelution;
@@ -33,19 +31,7 @@ public static class GeneralDrivelution
     /// <exception cref="PlatformNotSupportedException">Thrown when platform is not supported</exception>
     public static IGeneralDrivelution Create(DrivelutionOptions? options = null)
     {
-        var logger = LoggerConfigurator.ConfigureLogger(options);
-        return Core.DrivelutionFactory.Create(logger, options);
-    }
-
-    /// <summary>
-    /// Creates a driver updater instance (with custom logger)
-    /// </summary>
-    /// <param name="logger">Custom logger</param>
-    /// <param name="options">Configuration options (optional)</param>
-    /// <returns>Platform-adapted driver updater</returns>
-    public static IGeneralDrivelution Create(IDrivelutionLogger logger, DrivelutionOptions? options = null)
-    {
-        return Core.DrivelutionFactory.Create(logger, options);
+        return Core.DrivelutionFactory.Create(options);
     }
 
     /// <summary>
