Toast without timeout and reason for onClose (user or timeout) #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix #1706 and the comment #1708 (comment) |
|
Any updates? |
|
any updates on this? |
|
@danieloprado onClose is called twice with reason user and timeout, when duration is specified.
|
BenWildeman
reviewed
Apr 18, 2018
| @@ -102,7 +104,7 @@ class ToastContainer extends Component { | |||
| {this.state.buttonText && ( | |||
| <Button | |||
| style={this.state.buttonStyle} | |||
| onPress={() => this.closeToast()} | |||
| onPress={() => this.closeToast('user')} | |||
There was a problem hiding this comment.
change this line to cancel the this.closeTimeout when the user taps it
|
@akhil-geekyants that issue was there prior |
|
@akhil-geekyants the whole Toast component needs rethinking really. there's a few issues surrounding this |
|
Fixed! thanks for the feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If duration is equal to 0 disable the toast timeout to close.
Added the reason that toast was closed: "user" when user press the button or "timeout" where duration ends.