Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warning when no quantifiers are used in quantified logic #76

Open
mpreiner opened this issue Jul 19, 2021 · 4 comments
Open

No warning when no quantifiers are used in quantified logic #76

mpreiner opened this issue Jul 19, 2021 · 4 comments

Comments

@mpreiner
Copy link

It would be great if Dolmen warns if no quantifiers are used, but a quantified logic was specified:

For example for

(set-logic BV)
(declare-const a (_ BitVec 8))
(declare-const b (_ BitVec 8))
(assert (= a b))
(check-sat)

Dolmen parses the benchmark without any warning, however, it'd be great if it would inform the user that QF_BV would be sufficient for the logic.

@Gbury
Copy link
Owner

Gbury commented Jul 19, 2021

I'll add that warning (maybe behind a cli flag, but I'm not sure yet).

@hansjoergschurr
Copy link
Contributor

I wonder if this fits into the "find minimal logic" feature. The warning would be emitted on the (set-logic ...) line.

@Gbury
Copy link
Owner

Gbury commented Jul 21, 2021

This would indeed fit into the "minimal logic" feature, considering that dolmen would ultimately warn when a problem is set in a logic that is not the minimal one for the problem.
However, the minimal logic detection will likely take some time to be implemented (optimistically, i'd like to do it within about a year, but it's a very optimistic deadline), so the question is really whether it's okay to wait that long to have this warning.

@Gbury
Copy link
Owner

Gbury commented Apr 29, 2024

A first implementation of minimal logic detection is in #211. I'll probably add a warning that can be triggered (and made fatal if wanted) when the input logic of a problem is not minimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants