Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contact unit tests authenticity #271

Closed
Rahul-JOON opened this issue Jun 20, 2023 · 1 comment
Closed

Contact unit tests authenticity #271

Rahul-JOON opened this issue Jun 20, 2023 · 1 comment
Assignees
@Rahul-JOON
Labels
bug Something isn't working prio:high Priority level: high

Comments

@Rahul-JOON
Copy link
Contributor

The unit tests of the contact module are currently comparing the outputs with the kernel outputs of the same functions; the functions rather need to be compared with hand-crafted or analytically verified values.

I will work on this.
@Rahul-JOON Rahul-JOON added the bug Something isn't working label Jun 20, 2023
@bhosale2 bhosale2 added the prio:high Priority level: high label Jun 21, 2023
@Rahul-JOON Rahul-JOON mentioned this issue Jun 23, 2023
Merged
@Rahul-JOON
Copy link
Contributor Author

Closed via #274.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rahul-JOON Rahul-JOON

Labels
bug Something isn't working prio:high Priority level: high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bhosale2 @Rahul-JOON