Skip to content

Commit a4cb0a3

Browse files
committed
Cleanup OnError comments
Signed-off-by: Gareth Hancock <64541249+GazHank@users.noreply.github.com>
1 parent 0b7ca3e commit a4cb0a3

File tree

2 files changed

+0
-42
lines changed

2 files changed

+0
-42
lines changed

packages/bindings/src/darwin_list.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,6 @@ struct ListBaton : public Napi::AsyncWorker {
2828
char errorString[ERROR_STRING_SIZE];
2929
void Execute() override;
3030

31-
// void OnError(Napi::Error const &error) override {
32-
// Napi::Env env = Env();
33-
// Napi::HandleScope scope(env);
34-
// Callback().Call({Napi::String::New(env, errorString), env.Undefined()});
35-
// }
36-
3731
void OnOK() override {
3832
Napi::Env env = Env();
3933
Napi::HandleScope scope(env);

packages/bindings/src/serialport.h

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,6 @@ struct OpenBaton : public Napi::AsyncWorker {
7373
#endif
7474
void Execute() override;
7575

76-
// void OnError(Napi::Error const &error) override {
77-
// Napi::Env env = Env();
78-
// Napi::HandleScope scope(env);
79-
// Callback().Call({Napi::String::New(env, errorString), env.Undefined()});
80-
// }
81-
8276
void OnOK() override {
8377
Napi::Env env = Env();
8478
Napi::HandleScope scope(env);
@@ -97,12 +91,6 @@ struct ConnectionOptionsBaton : ConnectionOptions , Napi::AsyncWorker {
9791

9892
void Execute() override;
9993

100-
// void OnError(Napi::Error const &error) override {
101-
// Napi::Env env = Env();
102-
// Napi::HandleScope scope(env);
103-
// Callback().Call({Napi::String::New(env, errorString)});
104-
// }
105-
10694
void OnOK() override {
10795
Napi::Env env = Env();
10896
Napi::HandleScope scope(env);
@@ -125,12 +113,6 @@ struct SetBaton : public Napi::AsyncWorker {
125113

126114
void Execute() override;
127115

128-
// void OnError(Napi::Error const &error) override {
129-
// Napi::Env env = Env();
130-
// Napi::HandleScope scope(env);
131-
// Callback().Call({Napi::String::New(env, errorString)});
132-
// }
133-
134116
void OnOK() override {
135117
Napi::Env env = Env();
136118
Napi::HandleScope scope(env);
@@ -150,12 +132,6 @@ struct GetBaton : public Napi::AsyncWorker {
150132

151133
void Execute() override;
152134

153-
// void OnError(Napi::Error const &error) override {
154-
// Napi::Env env = Env();
155-
// Napi::HandleScope scope(env);
156-
// Callback().Call({Napi::String::New(env, errorString),env.Undefined()});
157-
// }
158-
159135
void OnOK() override {
160136
Napi::Env env = Env();
161137
Napi::HandleScope scope(env);
@@ -177,12 +153,6 @@ struct GetBaudRateBaton : public Napi::AsyncWorker {
177153

178154
void Execute() override;
179155

180-
// void OnError(Napi::Error const &error) override {
181-
// Napi::Env env = Env();
182-
// Napi::HandleScope scope(env);
183-
// Callback().Call({Napi::String::New(env, errorString),env.Undefined()});
184-
// }
185-
186156
void OnOK() override {
187157
Napi::Env env = Env();
188158
Napi::HandleScope scope(env);
@@ -197,12 +167,6 @@ struct VoidBaton : public Napi::AsyncWorker {
197167
errorString() {}
198168
int fd = 0;
199169
char errorString[ERROR_STRING_SIZE];
200-
201-
// void OnError(Napi::Error const &error) override {
202-
// Napi::Env env = Env();
203-
// Napi::HandleScope scope(env);
204-
// Callback().Call({Napi::String::New(env, errorString)});
205-
// }
206170

207171
void OnOK() override {
208172
Napi::Env env = Env();

0 commit comments

Comments
 (0)