Skip to content

EDGE-10005 Call Duration #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

brianroth-rl
Copy link
Contributor

@brianroth-rl brianroth-rl commented Aug 16, 2024

References: EDGE-10005
Code PR: https://github.com/GannettDigital/reach-analytics-reporting-service/pull/1958
Documentation: #385

Description:
A few sentences describing the overall goals of the pull request's commits.

Manual Migration:
Completed in staging and production already

CREATE TABLE marketing_activities_clone LIKE marketing_activities;

ALTER TABLE `marketing_activities` ADD `gt_60_count` int AFTER `count`;

INSERT INTO marketing_activities_clone (platform_id, master_advertiser_id, master_campaign_id, wpc_id, report_date, referrer_source, referrer_type, sub_type, count)
SELECT
	platform_id, master_advertiser_id, master_campaign_id, wpc_id, report_date, referrer_source, referrer_type, sub_type, count
FROM
	marketing_activities;

RENAME TABLE marketing_activities TO marketing_activities_old,
marketing_activities_clone TO marketing_activities;

Testing Instructions:
Call events with durations of 60 seconds or longer were added to demo data so

curl --location 'http://localhost:3001/client_reports/marketing_activity/TEST_1?start_date=2024-7-17&end_date=2024-8-15' \
--header 'Authorization: reachanalyticsreportingservicetoken'

works

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@brianroth-rl brianroth-rl force-pushed the EDGE_10005_call_duration branch from 34ce8fa to 5d5af9c Compare August 16, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant