From 73c8d414ed44bae6382f34035d099a2199ee1705 Mon Sep 17 00:00:00 2001
From: Jimmy Lai <laijimmy0@gmail.com>
Date: Mon, 12 Aug 2024 11:53:46 +0200
Subject: [PATCH] misc: add dd-trace to server externals (#68785)

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->

Unfortunately, dd-trace requires modules in some conditional fashion, as
some of our users reported, which is the usual pattern for tracing
packages. This PR works around this by marking the package to not be
compiled explicitly.

Fixes #64419

---------

Co-authored-by: Jiachi Liu <inbox@huozhi.im>
---
 .../05-next-config-js/serverExternalPackages.mdx                 | 1 +
 .../04-next-config-js/serverExternalPackages.mdx                 | 1 +
 packages/next/src/lib/server-external-packages.json              | 1 +
 3 files changed, 3 insertions(+)

diff --git a/docs/02-app/02-api-reference/05-next-config-js/serverExternalPackages.mdx b/docs/02-app/02-api-reference/05-next-config-js/serverExternalPackages.mdx
index 2583ab63d98ce..5bf1b79d02ca3 100644
--- a/docs/02-app/02-api-reference/05-next-config-js/serverExternalPackages.mdx
+++ b/docs/02-app/02-api-reference/05-next-config-js/serverExternalPackages.mdx
@@ -41,6 +41,7 @@ Next.js includes a [short list of popular packages](https://github.com/vercel/ne
 - `canvas`
 - `cpu-features`
 - `cypress`
+- `dd-trace`
 - `eslint`
 - `express`
 - `firebase-admin`
diff --git a/docs/03-pages/02-api-reference/04-next-config-js/serverExternalPackages.mdx b/docs/03-pages/02-api-reference/04-next-config-js/serverExternalPackages.mdx
index dcb66eb0abdeb..8e14ffdeaf279 100644
--- a/docs/03-pages/02-api-reference/04-next-config-js/serverExternalPackages.mdx
+++ b/docs/03-pages/02-api-reference/04-next-config-js/serverExternalPackages.mdx
@@ -41,6 +41,7 @@ Next.js includes a [short list of popular packages](https://github.com/vercel/ne
 - `canvas`
 - `cpu-features`
 - `cypress`
+- `dd-trace`
 - `eslint`
 - `express`
 - `firebase-admin`
diff --git a/packages/next/src/lib/server-external-packages.json b/packages/next/src/lib/server-external-packages.json
index 6dde1971f0667..092b0b32e4c3c 100644
--- a/packages/next/src/lib/server-external-packages.json
+++ b/packages/next/src/lib/server-external-packages.json
@@ -22,6 +22,7 @@
   "canvas",
   "cpu-features",
   "cypress",
+  "dd-trace",
   "eslint",
   "express",
   "firebase-admin",