Add incomplete download support (#198) #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add resumable downloads across app sessions * Remove debug print statements * cleanup and add new test cases * add download cancellation handling and fix download progress update * create target files right before moving and add etag to incomplete file names for versioning * properly cancel downloader task and fix formatting * remove unnecessary tabs in test cases --------- Co-authored-by: Anthony DePasquale <anthony@depasquale.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add resumable downloads across app sessions
Remove debug print statements
cleanup and add new test cases
add download cancellation handling and fix download progress update
create target files right before moving and add etag to incomplete file names for versioning
properly cancel downloader task and fix formatting
remove unnecessary tabs in test cases