Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scCryptolType: unsupported type sort 0 #1248

Open
msaaltink opened this issue Oct 14, 2020 · 3 comments
Open

scCryptolType: unsupported type sort 0 #1248

msaaltink opened this issue Oct 14, 2020 · 3 comments
Labels
needs test Issues for which we should add a regression test subsystem: saw-core Issues related to the saw-core representation or the saw-core subsystem type: bug Issues reporting bugs or unexpected/unwanted behavior
Milestone

Comments

@msaaltink
Copy link
Contributor

Executing

let bv64 = parse_core "bitvector 32";

results in

[17:36:02.544] You have encountered a bug in cryptol-saw-core's implementation.
*** Please create an issue at https://github.com/GaloisInc/saw-core/issues

%< --------------------------------------------------- 
  Revision:  cff300fce2caaf4be678bfdab8c8e3ade93d020f
  Branch:    HEAD
  Location:  scCryptolType
  Message:   scCryptolType: unsupported type sort 0
CallStack (from HasCallStack):
  panic, called at src/Verifier/SAW/Cryptol/Panic.hs:13:9 in cryptol-saw-core-0.1-7NBapC0zhks5IhYxksTPfp:Verifier.SAW.Cryptol.Panic
  panic, called at src/Verifier/SAW/Cryptol.hs:1400:19 in cryptol-saw-core-0.1-7NBapC0zhks5IhYxksTPfp:Verifier.SAW.Cryptol
%< --------------------------------------------------- 
@ghost
Copy link

ghost commented Feb 6, 2021

Stumbled across this with Prelude.Nat as well:

$ saw
version 0.7 (670e349-dirty)

sawscript> parse_core "4"

You have encountered a bug in cryptol-saw-core's implementation.
*** Please create an issue at https://github.com/GaloisInc/saw-core/issues

%< --------------------------------------------------- 
  Revision:  f61023ebbb34c2d6acbda9fc2eb2d0ba0884604c
  Branch:    HEAD
  Location:  scCryptolType
  Message:   scCryptolType: unsupported type Prelude.Nat
CallStack (from HasCallStack):
  panic, called at src/Verifier/SAW/Cryptol/Panic.hs:13:9 in cryptol-saw-core-0.1-Bsnj23LjNlkEA2Ker1hOsY:Verifier.SAW.Cryptol.Panic
  panic, called at src/Verifier/SAW/Cryptol.hs:1540:19 in cryptol-saw-core-0.1-Bsnj23LjNlkEA2Ker1hOsY:Verifier.SAW.Cryptol
%< --------------------------------------------------- 

sawscript>

@brianhuffman brianhuffman transferred this issue from GaloisInc/saw-core Apr 27, 2021
@brianhuffman brianhuffman added the subsystem: saw-core Issues related to the saw-core representation or the saw-core subsystem label Apr 27, 2021
@RyanGlScott
Copy link
Contributor

I believe this is fixed now? On a recent checkout of master, neither of the following appear to crash:

sawscript> parse_core "Vec 32 Bool"
[15:37:21.828] Prelude.Vec 32 Prelude.Bool
sawscript> parse_core "4"
[15:37:23.726] 4

(I'm assuming that bitvector n is an alias for Vec n Bool.)

@robdockins
Copy link
Contributor

Yes, this was fixed via #1336. It's probably worthwhile to keep this ticket open until we add a test case.

@robdockins robdockins added the needs test Issues for which we should add a regression test label Jun 21, 2021
@sauclovian-g sauclovian-g added the type: bug Issues reporting bugs or unexpected/unwanted behavior label Oct 29, 2024
@sauclovian-g sauclovian-g added this to the 2024T3 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs test Issues for which we should add a regression test subsystem: saw-core Issues related to the saw-core representation or the saw-core subsystem type: bug Issues reporting bugs or unexpected/unwanted behavior
Projects
None yet
Development

No branches or pull requests

5 participants