Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest version of types-requests #1645

Closed
mccleeary-galois opened this issue Mar 19, 2024 · 2 comments · Fixed by #1660
Closed

Support latest version of types-requests #1645

mccleeary-galois opened this issue Mar 19, 2024 · 2 comments · Fixed by #1660
Labels
remote-api Related to Cryptol's remote API

Comments

@mccleeary-galois
Copy link
Contributor

mccleeary-galois commented Mar 19, 2024

Currently types-requests is locked due to breaking CI, see #1643. We will want to eventually support the latest version.

@RyanGlScott RyanGlScott changed the title Support latest version of requests-types Support latest version of types-requests Mar 19, 2024
@RyanGlScott
Copy link
Contributor

See https://github.com/GaloisInc/cryptol/actions/runs/8324626968/job/22777200617#step:13:45 for an example of the breakage:

 /home/runner/.cache/pypoetry/virtualenvs/cryptol-mHP-LW8h-py3.11/lib/python3.11/site-packages/requests-stubs/structures.pyi:21: error: Positional-only parameters are only supported in Python 3.8 and greater  [syntax]

It's not clear to me why this error happens, since we are specifically using Python 3.11 in the CI.

@sauclovian-g
Copy link
Contributor

One common cause of that is matching versions with patterns like python3.[8-9] that aren't actually comparisons. Although you'd think it would have broken long ago on 3.10 if that were the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remote-api Related to Cryptol's remote API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants