Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uses of imperative SHA2 with spec-adherent SHA2 #122

Open
3 tasks
marsella opened this issue Aug 23, 2024 · 0 comments
Open
3 tasks

Replace uses of imperative SHA2 with spec-adherent SHA2 #122

marsella opened this issue Aug 23, 2024 · 0 comments
Labels
CNSA 2.0 improvement Addresses fixes or changes to existing specs

Comments

@marsella
Copy link
Contributor

marsella commented Aug 23, 2024

Several spots throughout the code use the imperative version of SHA2, instead of the more obviously-spec-adherent version added in #112. We should try to replace these with the spec version.

Optional: maybe block on #98 in case some of these uses are actually generic over the hash?

  • Identify all uses and determine which need the imperative version specifically
  • Decide whether to remove the imperative version. If not, add a README explaining when to use each version. If so, delete it.
  • Add notes to SHA-2 spec that it'll be eventually superseded by SHA-3
@mccleeary-galois mccleeary-galois added enhancement New feature or request CNSA 2.0 labels Aug 29, 2024
@marsella marsella added improvement Addresses fixes or changes to existing specs and removed enhancement New feature or request labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CNSA 2.0 improvement Addresses fixes or changes to existing specs
Projects
None yet
Development

No branches or pull requests

2 participants