Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe void mode does not do anything, button should be removed #17900

Open
3 tasks done
Alexdoru opened this issue Nov 8, 2024 · 4 comments
Open
3 tasks done

Safe void mode does not do anything, button should be removed #17900

Alexdoru opened this issue Nov 8, 2024 · 4 comments
Labels
Mod: GT GregTech and its (former) addons Status: Ready for Developer Issue ready for a developer to pick up and implement Suggestion Type: GUI

Comments

@Alexdoru
Copy link
Member

Alexdoru commented Nov 8, 2024

Your GTNH Discord Username

Alexdoru

Your Pack Version

GTNH 2.7.0 beta 3

Your Server

solo

Java Version

Java 21

Type of Server

None

Your Expectation

The Space pumping module of the space elevator has a "safe void" button and I expect the pump to stop pumping when the hatch is full

The Reality

it doesn't stop

Your Proposal

fix, and also make safe void the default behavior

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@Alexdoru Alexdoru added Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed labels Nov 8, 2024
@chochem chochem added Suggestion Status: Ready for Developer Issue ready for a developer to pick up and implement and removed Status: Triage Issue awaiting triage. Remove once this issue is processed labels Nov 8, 2024
@chochem
Copy link
Member

chochem commented Nov 8, 2024

actually wait, you say safe void. not void protection. thats a different thing

@chochem chochem added Type: Not a Bug Is not actually a bug. and removed Status: Ready for Developer Issue ready for a developer to pick up and implement Bug: Minor labels Nov 8, 2024
@chochem
Copy link
Member

chochem commented Nov 8, 2024

safe void is from tectech EM (dead unfinished feature from years ago)

@chochem chochem closed this as not planned Won't fix, can't repro, duplicate, stale Nov 8, 2024
@wlhlm
Copy link
Member

wlhlm commented Nov 8, 2024

If it's unfinished and there's no desire to implement it, then we should at least remove the button to avoid confusion.

@wlhlm wlhlm reopened this Nov 8, 2024
@wlhlm wlhlm changed the title Space Elevator pump safe void mode doesn't work Space Elevator pump safe void mode doesn't work, button should be removed Nov 8, 2024
@wlhlm wlhlm removed the Type: Not a Bug Is not actually a bug. label Nov 8, 2024
@chochem chochem changed the title Space Elevator pump safe void mode doesn't work, button should be removed Safe void mode doesn't not do anything, button should be removed Nov 9, 2024
@chochem chochem added Mod: GT GregTech and its (former) addons and removed Mod: GTNH-Intergalactic labels Nov 9, 2024
@chochem chochem changed the title Safe void mode doesn't not do anything, button should be removed Safe void mode does not do anything, button should be removed Nov 9, 2024
@chochem
Copy link
Member

chochem commented Nov 9, 2024

this is not about intergalatic or galaxyspace then. this is a tectech feature (now gt)

@chochem chochem added the Status: Ready for Developer Issue ready for a developer to pick up and implement label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: GT GregTech and its (former) addons Status: Ready for Developer Issue ready for a developer to pick up and implement Suggestion Type: GUI
Projects
None yet
Development

No branches or pull requests

5 participants