Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix essentia search NPE #26

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Fix essentia search NPE #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2144eb5
Update dependencies and buildscript
wlhlm Nov 19, 2024
ad3f84b
Fix NPE when searching in inventories containing items with aspects i…
wlhlm Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions dependencies.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
// Add your dependencies here

dependencies {
implementation('com.github.GTNewHorizons:NotEnoughItems:2.6.44-GTNH:dev')
implementation('com.github.GTNewHorizons:NotEnoughItems:2.6.46-GTNH:dev')

compileOnly('com.github.GTNewHorizons:GT5-Unofficial:5.09.50.53:dev')
compileOnly('com.github.GTNewHorizons:EnderIO:2.8.20:dev')
compileOnly('com.github.GTNewHorizons:GT5-Unofficial:5.09.50.72:dev')
compileOnly('com.github.GTNewHorizons:EnderIO:2.8.22:dev')
compileOnly('com.github.GTNewHorizons:Draconic-Evolution:1.3.13-GTNH:dev')
compileOnly('com.github.GTNewHorizons:ForestryMC:4.9.16:dev')
compileOnly('com.github.GTNewHorizons:AdventureBackpack2:1.2.3-GTNH:dev')
compileOnly('com.github.GTNewHorizons:ForestryMC:4.9.18:dev')
compileOnly('com.github.GTNewHorizons:AdventureBackpack2:1.2.4-GTNH:dev')
compileOnly("com.github.GTNewHorizons:ProjectRed:4.10.5-GTNH:dev")
compileOnly("com.github.GTNewHorizons:Minecraft-Backpack-Mod:2.4.3-GTNH:dev")
compileOnly("curse.maven:thaumcraft-nei-plugin-225095:2241913")
compileOnly("thaumcraft:Thaumcraft:1.7.10-4.2.3.5:dev")

// For testing in dev environment.
// runtimeOnlyNonPublishable('com.github.GTNewHorizons:StorageDrawers:2.0.3-GTNH')
// runtimeOnlyNonPublishable("com.github.GTNewHorizons:waila:1.8.1")
// runtimeOnlyNonPublishable("com.github.GTNewHorizons:waila:1.8.2")
// runtimeOnlyNonPublishable('thaumcraft:Thaumcraft:1.7.10-4.2.3.5:dev')
// runtimeOnlyNonPublishable("com.github.GTNewHorizons:Baubles:1.0.4:dev")
// runtimeOnlyNonPublishable('curse.maven:thaumcraft-nei-plugin-225095:2241913')
Expand Down
2 changes: 1 addition & 1 deletion settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ pluginManagement {
}

plugins {
id 'com.gtnewhorizons.gtnhsettingsconvention' version '1.0.27'
id 'com.gtnewhorizons.gtnhsettingsconvention' version '1.0.29'
}


2 changes: 1 addition & 1 deletion src/main/java/com/gtnh/findit/handler/ThaumcraftProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public boolean matches(FindItemRequest request) {
if (!(item instanceof ItemAspect || item instanceof IEssentiaContainerItem)) return false;

AspectList stackAspects = ItemAspect.getAspects(stack);
if (stackAspects.size() != 1) return false;
if (stackAspects == null || stackAspects.size() != 1) return false;

Aspect stackAspect = stackAspects.getAspects()[0];

Expand Down