Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve example images for "What is Geodata?" section #57

Closed
ioalexei opened this issue May 10, 2024 · 4 comments
Closed

Improve example images for "What is Geodata?" section #57

ioalexei opened this issue May 10, 2024 · 4 comments
Labels

Comments

@ioalexei
Copy link
Collaborator

In the What is Geodata subsection under Module 2: Intro to geodata, the supporting images could be improved.

"In the case of the geometric representation of features vs table form, or in the case of the table where non-geographic attributes are just ID codes and are not helpful to explain the difference between spatial and non-spatial information

Something like the images below would be a better support to explain those concepts:
image
"
(Francesco C. can provide the original quality versions of the images in this screenshot)

@ioalexei ioalexei changed the title Improve example images for ___What is Geodata___ section Improve example images for "What is Geodata?" section May 10, 2024
@ioalexei
Copy link
Collaborator Author

  • Related comment: On Fig 15 - the name is not spatial information, image should be updated

@enauj enauj added the module 2 label Aug 20, 2024
enauj added a commit that referenced this issue Sep 2, 2024
@enauj
Copy link
Collaborator

enauj commented Sep 2, 2024

Improved the introduction of geodata and explanation of vector data with the BRC material.
(6849ba2)

https://giscience.github.io/gis-training-resource-center/content/Modul_2/en_qgis_geodata_concept.html

Feedback is appreciated.

@enauj enauj closed this as completed Sep 2, 2024
@ioalexei
Copy link
Collaborator Author

This is looking great! Apologies for being slow to review. Some initial comments from reading through the updated content:

  1. Under vector file formats:
  • in the table it says gpkg is the new standard, but it's not mentioned in the part below, 'Most common formats'
  • It says gdb and geojson are similar to shapefile - not sure I agree with this?
  • KMZ is included without an explanation on what it is
  • GDB is mentioned in common formats but isn't in the table
  • I think it's worth noting that GDB and GPKG are databases compared to the others which are files
  • Think important to note geojson can't store projection info & is conventionally limited to WGS84

Perhaps we could remove the second section, "Most common formats" and just use the table to convey the necessary information?

  1. Under raster data formats, can we remind that gdb and gpkg can hold raster data?
  2. Under 'The layer concept', there's a reference to CartONG. Looking at the linked material, I think it's ok to just keep the CartONG reference in the image caption and leave out the one in the text - since we aren't using text references/footnotes elsewhere.
  3. The TrueSizeOf embed doesn't work for me - it has an undismissable popup and a note underneath about it being embedded. I think the embed can be remove anyway, since there is already a screenshot and a link to the page.
  4. Under 'How to choose an appropriate projected coordinate system' it says "The data and the project should always be the same, or else you will get wrong results! " - this isn't quite right. Data and project can have different CRS and QGIS will reconcile them. But they need to be in the same CRS for accurate analysis against other layers and various other operations. Think it's also important to note that every data set should have it's own CRS and that changing a layer's CRS to something it wasn't encoded in will result in errors.
  5. "EPSG" needs to be explained on first use - and perhaps explain the difference between the CRS name and EPSG code?
  6. Source link for fig 24 doesn't work for me
  7. Fig 26-29 are missing source info
  8. In the discussion of different reference systems, it might be helpful to show an example of different coordinate systems for the same point - e.g. (44.173, 5.278) in WGS84 is (1912532.92, 835466.28) in ED50 (epsg:2192)

@enauj enauj reopened this Sep 12, 2024
enauj added a commit that referenced this issue Oct 28, 2024
@enauj
Copy link
Collaborator

enauj commented Oct 28, 2024

added the points from the feedback in commit e316bf5

@enauj enauj closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants