Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About having graph in the States #153

Open
wang422003 opened this issue Feb 8, 2024 · 5 comments
Open

About having graph in the States #153

wang422003 opened this issue Feb 8, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request high priority Let's do these first!
Milestone

Comments

@wang422003
Copy link

Hello and thank you for developing the torchgfn package! It's been a fantastic resource, and I appreciate all the work that's gone into it.

I'm exploring the package and am particularly interested in integrating graph data within the states, specifically including node features and the adjacency matrix. However, I'm currently unsure of the best approach to achieve this within the framework of torchgfn.

Could you provide any guidance, instructions, or suggestions on how to incorporate graph structures into the states? Any help or pointers towards relevant documentation or examples would be greatly appreciated!

@josephdviviano
Copy link
Collaborator

This is something we're also interested in building into torchgfn.

I believe we would need to take inspiration from https://github.com/recursionpharma/gflownet to do it properly.

This is one of a few major features that need to be added to the package for it to be fully featured. Would you be interested in assisting on the development of this?

@josephdviviano josephdviviano added the enhancement New feature or request label Feb 16, 2024
@wang422003
Copy link
Author

Many thanks for the reply! I will definitely check the link.

I am really interested in GFlowNet and interested in assisting on the development of getting graphs in the states!

@josephdviviano
Copy link
Collaborator

@saleml for reference : https://github.com/recursionpharma/gflownet/blob/ef5f2cbb14f3f35bc2b95d33b9b3cf86cc558d17/src/gflownet/envs/graph_building_env.py#L18

@wang422003 for now, if you want a library that works well with graphs, you can check the above work from Emmanuel Bengio's group at Recursion. We plan to support similar functionality but it will take us some time to decide exactly how.

@wang422003
Copy link
Author

@wang422003 for now, if you want a library that works well with graphs, you can check the above work from Emmanuel Bengio's group at Recursion. We plan to support similar functionality but it will take us some time to decide exactly how.

Many thanks for sharing. Actually, I checked the link and figured out that their current implementation only supports undirected graphs. So I am now thinking about how to make it work for directed graphs as well.

@josephdviviano
Copy link
Collaborator

josephdviviano commented Feb 21, 2024

We would love to collaborate with you on this, this would be quite useful for multiple domains and some older work that was never successfully integrated e.g., #26

It seems very likely we should be heavily influenced by this project https://github.com/tristandeleu/jax-dag-gflownet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority Let's do these first!
Projects
None yet
Development

No branches or pull requests

4 participants