Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gridphycics Game are given non-defined sprites. #7

Open
HuskyNator opened this issue Jun 11, 2020 · 2 comments
Open

Gridphycics Game are given non-defined sprites. #7

HuskyNator opened this issue Jun 11, 2020 · 2 comments

Comments

@HuskyNator
Copy link

When a gridphysics game, not containing a 'wall' sprite, is created & it's sprites are looped over:

VGDLFactory.GetInstance().init();
VGDLRegistry.GetInstance().init();
Game game = VGDLParser().parseGame(gamePath);
GameDescription gameDescription = GameDescription(game);
ArrayList<SpriteData> sprites  = gameDescription.getAllSpriteData();
for(Spritedata sprite: sprites){
    System.out.println(sprite);
}

A 'wall' sprite is found, namely: wall > Immovable solid=True color=DARKGRAY.
Even though this wall was not defined by the game file.
Examples of games having this issue are: waves, zenpuzzle.

As far as I am aware this is non-documented behavior, and is not desired.
(I tried to use the interaction data to find sprites with certain properties, like walls and floors, however as this sprite is added, and it does not include any StepBack interactions with defined avatars, I often incorrectly identify it as the floor.

If I may also add this: It may be good to add a disclaimer to the wiki, to clarify the interactiondata ,received from the gamedescription objects, start with capital letters, as opposed to their VGDL and wiki definitions (such as "stepBack" vs "StepBack").

@amidos2006
Copy link
Collaborator

I remember that wall and avatar sprites are automatically added to the objects as a default action (which no one is using any more). I would agree with you to remove that feature since none of the current games is using it. For the other part about the names to be capitalized, maybe you could modify it directly in the wiki if possible :)

Sorry for any inconvenience.

@HuskyNator
Copy link
Author

HuskyNator commented Jun 13, 2020

It hasn't been much of an inconvenience at all as it was pretty simple to get around,
I was unaware i could change any wiki content,
Some parts of the wiki seem to be incorrect, but I wouldn't know how to correct them,
For example; "MultiSpriteCounterSubTypes" has, im assuming, the properties that are actually part of "MultiSpriteCounter" (in the termination conditions page), but im not sure.
Or 'TransformToAll', as it is missing from the wiki.

Additionally my appologies, but due to being unsure where to ask this, is there any way to find out what the 'subTypesNum' parameter of "MultiSpriteCounterSubTypes" terminations are from the TerminationData?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants