Add EnableStoreDecimalAsInteger to WriterProperties#572
Merged
adamreeve merged 3 commits intoG-Research:masterfrom Oct 15, 2025
Merged
Add EnableStoreDecimalAsInteger to WriterProperties#572adamreeve merged 3 commits intoG-Research:masterfrom
adamreeve merged 3 commits intoG-Research:masterfrom
Conversation
adamreeve
reviewed
Oct 12, 2025
Contributor
adamreeve
left a comment
adamreeve
left a comment
There was a problem hiding this comment.
This looks good thanks @haianhng31, I just have some feedback to make the comments clearer.
adamreeve
previously approved these changes
Oct 13, 2025
Contributor
|
Looks like the CI errors are unrelated to these changes but might be due to changes in vcpkg. I've made an issue for this: #574 |
haianhng31
force-pushed
the
writerproperties
branch
from
55a1f07 to
4157d5b
Compare
adamreeve
approved these changes
Oct 15, 2025
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #556