Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDF Converter, XML Reader Updates #325

Merged
merged 15 commits into from
Sep 27, 2019
Merged

RDF Converter, XML Reader Updates #325

merged 15 commits into from
Sep 27, 2019

Conversation

fschrader1992
Copy link
Collaborator

This pull request

@fschrader1992
[tools/xmlparser.py] Object Creation Errors to Warnings in Save Mode
5ffb743 
If ignore_errors is set, errors from object creation are converted
to warnings.

Related to issue G-Node#276.
@fschrader1992
[text_parser_xml.py] Add Test for ignore_errors Mode
45ca2bc 
Including sample file.

Related to issue G-Node#276.
@fschrader1992
[RDFWriter] Fix Broken Install Via Manifest
4e4cdae 
By adding section_subclasses.yaml to MANIFEST the quick fix in
rdf_converter.py/RDFWriter is replaced.

Related to issue G-Node#212.
@fschrader1992
[doc.py] Fix Wrong Indentation for pprint()
a502115
@fschrader1992
[rdf_converter.py/RDFWriter] Remove Comment
6b688af
@coveralls
Copy link

coveralls commented Aug 20, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.8%) to 76.856% when pulling b86309e on fschrader1992:master into ae2474d on G-Node:master.

mpsonntag
mpsonntag requested changes Sep 13, 2019
View reviewed changes
odml/tools/rdf_converter.py Outdated Show resolved Hide resolved
mpsonntag
mpsonntag reviewed Sep 23, 2019
View reviewed changes
odml/tools/xmlparser.py Outdated Show resolved Hide resolved
mpsonntag
mpsonntag requested changes Sep 23, 2019
View reviewed changes
odml/tools/xmlparser.py Outdated Show resolved Hide resolved
@fschrader1992
[ignore_errors.xml] Change for Section Testing
09fcb09
@fschrader1992
[xmlparser.py] ignore_errors: Change Object Initialization
171a20f 
From Null to current type (Document, Section, Property).

Related to issue G-Node#276.
@fschrader1992
[rdf_converter.py] Add subclass_path Check Again
d18e5be
@fschrader1992
[ignore_errors.xml] Add Further Test Cases
b209dc0 
Related to issue G-Node#276.
@fschrader1992
[xmlparser.py] Catch ValueError at Object Creation
8f18f02 
Add more Specific Error Message.

Related to issue G-Node#276.
@fschrader1992
[xmlparser.py] Remove Useless Import Statement
9beda58 
Related to issue G-Node#276.
@fschrader1992
[xmlparser.py] Whitespace Adjustments in Error Messages
5991ede
@fschrader1992
[text_parser_xml.py] Check Exceptions of ignore_error.xml File
9c32cfb 
Related to issue G-Node#276.
@fschrader1992
[xmlparser.py] Revert Catch ValueError at Object Creation
420075f 
Catch all Exceptions.

Related to issue G-Node#276.
@fschrader1992
[ignore_errors.xml] Add Further Wrong Date Type Test
b86309e
@mpsonntag mpsonntag merged commit 15bb570 into G-Node:master Sep 27, 2019
@mpsonntag mpsonntag mentioned this pull request Sep 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpsonntag mpsonntag mpsonntag requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XMLReader potentially crashes on entity init RDFWriter broken on install
3 participants
@fschrader1992 @coveralls @mpsonntag