Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDFWriter broken on install #212

Closed
mpsonntag opened this issue Jan 24, 2018 · 6 comments · Fixed by #325
Closed

RDFWriter broken on install #212

mpsonntag opened this issue Jan 24, 2018 · 6 comments · Fixed by #325
Assignees
@fschrader1992
Labels
RDF

Comments

@mpsonntag
Copy link
Contributor

Currently the RDFWriter is broken when odml is installed, since a required file doc.section_subclasses.yaml is not exported on install.
@mpsonntag mpsonntag mentioned this issue Jan 25, 2018
Merged
@mpsonntag mpsonntag added the RDF label Apr 5, 2018
@fschrader1992 fschrader1992 self-assigned this Aug 12, 2019
fschrader1992 added a commit to fschrader1992/python-odml that referenced this issue Aug 20, 2019
@fschrader1992
[RDFWriter] Fix Broken Install Via Manifest
4e4cdae 
By adding section_subclasses.yaml to MANIFEST the quick fix in
rdf_converter.py/RDFWriter is replaced.

Related to issue G-Node#212.
@fschrader1992 fschrader1992 mentioned this issue Aug 20, 2019
Merged
@mpsonntag mpsonntag reopened this Sep 30, 2019
@mpsonntag
Copy link
Contributor Author

Issue was not fixed with #325.

@fschrader1992
Copy link
Collaborator

This could be fixed by moving the file into the odml directory. The question is, where exactly, either in the odml/tools folder, odml itself or into a new folder odml/resources, where other files could be stored as well.

@mpsonntag
Copy link
Contributor Author

I would either use a folder odml/resources or odml/tools/resources and move the file doc/section_subclasses,yaml there.

@achilleas-k
Copy link
Member

achilleas-k commented Nov 4, 2019 •
edited
Loading

I agree, resources would be a better location. Keep the non-code resources separate from the code.

@jgrewe
Copy link
Member

jgrewe commented Nov 4, 2019

👍 for a resources folder, I guess I would try to keep it flat and vote for odml/resources

@achilleas-k
Copy link
Member

Right, should have specified odml/resources is my vote too.

@jgrewe jgrewe closed this as completed in 01b8aec Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fschrader1992 fschrader1992

Labels
RDF
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RDF Converter, XML Reader Updates fschrader1992/python-odml
4 participants
@jgrewe @achilleas-k @mpsonntag @fschrader1992