Skip to content

Commit db25cc6

Browse files
authored
fix(release): add missed detekt pre-check and workflow_call (#154)
* fix(release): add missed workflow_call * fix(release): add missed detekt pre-check
1 parent 7534608 commit db25cc6

File tree

8 files changed

+28
-11
lines changed

8 files changed

+28
-11
lines changed

.github/workflows/codeql.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ on:
2020
- cron: '39 6 * * 1'
2121
# Allows you to run this workflow manually from the Actions tab
2222
workflow_dispatch:
23+
# Triggers the workflow on call from another workflow
24+
workflow_call:
2325

2426
jobs:
2527
analyze:

.github/workflows/detekt.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ on:
2727
- cron: '25 6 * * 1'
2828
# Allows you to run this workflow manually from the Actions tab
2929
workflow_dispatch:
30+
# Triggers the workflow on call from another workflow
31+
workflow_call:
3032

3133
# A workflow run is made up of one or more jobs that can run sequentially or in parallel
3234
jobs:

.github/workflows/e2e-test-fusionauth-latest-android-latest.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ on:
1414
- cron: '20 6 * * 1'
1515
# Allows you to run this workflow manually from the Actions tab
1616
workflow_dispatch:
17+
# Triggers the workflow on call from another workflow
18+
workflow_call:
1719

1820
env:
1921
fusionauth-docker-image-version: "latest"

.github/workflows/e2e-test-fusionauth-latest-android-matrix.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ on:
1414
branches: [ "main" ]
1515
# Allows you to run this workflow manually from the Actions tab
1616
workflow_dispatch:
17+
# Triggers the workflow on call from another workflow
18+
workflow_call:
1719

1820
env:
1921
fusionauth-docker-image-version: "1.55.1"

.github/workflows/e2e-test-fusionauth-matrix-android-latest.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ name: E2E Test with FusionAuth supported versions
1515
on:
1616
# To allow running this workflow manually from the Actions tab we add:
1717
workflow_dispatch:
18-
# Triggers the workflow on push request events but only for tag versions
18+
# Triggers the workflow on call from another workflow
1919
workflow_call:
2020

2121
# A workflow run is made up of one or more jobs that can run sequentially or in parallel

.github/workflows/lint.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ on:
2121
branches: [ "main" ]
2222
# Allows you to run this workflow manually from the Actions tab
2323
workflow_dispatch:
24+
# Triggers the workflow on call from another workflow
25+
workflow_call:
2426

2527
# A workflow run is made up of one or more jobs that can run sequentially or in parallel
2628
jobs:

.github/workflows/mobsf.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ on:
1414
- cron: '30 6 * * 1'
1515
# Allows you to run this workflow manually from the Actions tab
1616
workflow_dispatch:
17+
# Triggers the workflow on call from another workflow
18+
workflow_call:
1719

1820
permissions:
1921
contents: read

.github/workflows/release.yml

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -48,32 +48,37 @@ jobs:
4848
gh label create "autorelease: snapshot" -c D4C5F9 -d "release-please PR tagging - Ready for release" || true
4949
gh label create "autorelease: published" -c 0E8A16 -d "release-please PR tagging - Released" || true
5050
51+
# This job runs a CodeQL scan as a prerequisite for the prerelease-prep
52+
codeql:
53+
name: Run Prerelease CodeQL Package Scan
54+
uses: ./.github/workflows/codeql.yml
55+
56+
# This job runs a detekt scan as a prerequisite for the prerelease-prep
57+
detekt:
58+
name: Run Prerelease CodeQL Package Scan
59+
uses: ./.github/workflows/detekt.yml
60+
5161
# This job runs a simple E2E test with the latest FusionAuth and iOS version as a prerequisite for the prerelease-prep
5262
initial-e2e-test:
5363
name: Run Prerelease E2E Tests
5464
uses: ./.github/workflows/e2e-test-fusionauth-latest-android-latest.yml
5565

56-
# This job runs a MobSF scan as a prerequisite for the prerelease-prep
57-
mobsf:
58-
name: Run Prerelease MobSF Scan
59-
uses: ./.github/workflows/mobsf.yml
60-
6166
# This job runs a Lint scan as a prerequisite for the prerelease-prep
6267
lint:
6368
name: Run Prerelease Lint
6469
uses: ./.github/workflows/lint.yml
6570

66-
# This job runs a CodeQL scan as a prerequisite for the prerelease-prep
67-
codeql:
68-
name: Run Prerelease CodeQL Package Scan
69-
uses: ./.github/workflows/codeql.yml
71+
# This job runs a MobSF scan as a prerequisite for the prerelease-prep
72+
mobsf:
73+
name: Run Prerelease MobSF Scan
74+
uses: ./.github/workflows/mobsf.yml
7075

7176
# This job creates or finalizes a prerelease pull request or finalizes a release pull request
7277
# and provides the necessary outputs for the subsequent jobs
7378
prerelease-prep:
7479
name: Create Prerelease Pull Request
7580
runs-on: ubuntu-latest
76-
needs: [ label-check, initial-e2e-test, mobsf, lint, codeql ]
81+
needs: [ label-check, codeql, detekt, initial-e2e-test, lint, mobsf ]
7782
outputs:
7883
# This output is used to determine if a release was created
7984
releases_created: ${{ steps.release.outputs.releases_created }}

0 commit comments

Comments
 (0)