Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests for lower port #2253

Closed
oliverfunk opened this issue May 15, 2023 · 1 comment · Fixed by #2981
Closed

Improve tests for lower port #2253

oliverfunk opened this issue May 15, 2023 · 1 comment · Fixed by #2981
Assignees
Labels
EU-DEMO Tasks relating to the EU-DEMO project

Comments

@oliverfunk
Copy link
Contributor

Description of issue / requirement to address

More and better tests are needed for the lower port duct.
The designer and builder were thoroughly tested during development, currently, however, only the angle of the duct is tested is unit tested.

It's a complex challenge writing tests that capture validly between in the input params and the output, hence this issue.

Some tests that could be implemented:

  • Does the xz KOZ match an xz slice of the output xyz cad?
  • Is the width and height of the port correct?
  • Is the tf_offset correctly applied? Does the angled duct end at the correct place?
  • Is the tf_thickness correctly taken into account when designing the angled extrude face?
@oliverfunk oliverfunk added the EU-DEMO Tasks relating to the EU-DEMO project label May 15, 2023
@oliverfunk
Copy link
Contributor Author

LInked PR #2108

@je-cook je-cook self-assigned this Jan 23, 2024
@je-cook je-cook mentioned this issue Feb 2, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EU-DEMO Tasks relating to the EU-DEMO project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants