Skip to content

Conversation

@NotHyper-474
Copy link

@NotHyper-474 NotHyper-474 commented Mar 26, 2025

A contribution towards FunkinCrew/Funkin#4366

I'm not sure if I'll implement audio streaming with this Nevermind.

This could at least serve as a founding ground.

@NotHyper-474

This comment was marked as outdated.

@NotHyper-474
Copy link
Author

There seems to be a memory leak somewhere. To be investigated.

@NotHyper-474
Copy link
Author

NotHyper-474 commented Apr 11, 2025

I tried without SDL_sound and the "leak" is also present in the other implementations. Hmm....
It's as if the bytes loaded for the songs were never de-allocated. I suppose this is just how it works then and that either the GC or Lime frees them eventually.

I'll debug with Tracy just to be sure.

I think it's just that now it uses more memory since now it actually decodes the song data as its respective format instead of always retrieving 16bit audio format (at least for the original OGG decoder).

@ACrazyTown
Copy link

Could this also be pull requested to upstream Lime? From what I've seen it just brings the SDL_sound branch up to speed so it would be useful to have this there as well

@NotHyper-474
Copy link
Author

Could this also be pull requested to upstream Lime? From what I've seen it just brings the SDL_sound branch up to speed so it would be useful to have this there as well

I might consider it, I wouldn't like to gatekeep it to Funkin'.

@NotHyper-474
Copy link
Author

There seems to be a memory leak somewhere. To be investigated.

Huh, it seems to be gone. No idea what was causing it or how it got fixed but good riddance.

@NotHyper-474
Copy link
Author

NotHyper-474 commented Jun 8, 2025

Managed to get audio streaming working. I think that would be it, but I feel like I may be forgetting something.

@NotHyper-474 NotHyper-474 marked this pull request as ready for review July 24, 2025 18:49
@NotHyper-474 NotHyper-474 changed the title [WIP] Use SDL_sound on native for more audio type support Use SDL_sound on native for more audio type support Jul 24, 2025
@NotHyper-474 NotHyper-474 changed the base branch from dev-funkin to mobile/main September 19, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants