-
Notifications
You must be signed in to change notification settings - Fork 22
Use SDL_sound on native for more audio type support #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mobile/main
Are you sure you want to change the base?
Use SDL_sound on native for more audio type support #12
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
There seems to be a memory leak somewhere. To be investigated. |
|
I think it's just that now it uses more memory since now it actually decodes the song data as its respective format instead of always retrieving 16bit audio format (at least for the original OGG decoder). |
|
Could this also be pull requested to upstream Lime? From what I've seen it just brings the SDL_sound branch up to speed so it would be useful to have this there as well |
I might consider it, I wouldn't like to gatekeep it to Funkin'. |
Huh, it seems to be gone. No idea what was causing it or how it got fixed but good riddance. |
|
Managed to get audio streaming working. I think that would be it, but I feel like I may be forgetting something. |
de67731 to
b2f5add
Compare
b2f5add to
3cb4001
Compare
A contribution towards FunkinCrew/Funkin#4366
I'm not sure if I'll implement audio streaming with thisNevermind.This could at least serve as a founding ground.