update

Author: luoluoyuyu

cli/cli/src/repl.rs

@@ -26,7 +26,7 @@ use tonic::Request;
 #[derive(Debug, thiserror::Error)]
 pub enum ReplError {
     #[error("RPC error: {0}")]
-    Rpc(#[from] tonic::Status),
+    Rpc(Box<tonic::Status>),
     #[error("Connection failed: {0}")]
     Connection(String),
     #[error("Internal error: {0}")]
@@ -35,6 +35,12 @@ pub enum ReplError {
     Io(#[from] io::Error),
 }
 
+impl From<tonic::Status> for ReplError {
+    fn from(s: tonic::Status) -> Self {
+        ReplError::Rpc(Box::new(s))
+    }
+}
+
 pub struct Repl {
     client: Option<FunctionStreamServiceClient<tonic::transport::Channel>>,
     server_host: String,

src/config/paths.rs

@@ -38,7 +38,7 @@ fn resolve_project_root() -> std::io::Result<PathBuf> {
     if let Ok(exe_path) = env::current_exe() {
         let mut path = exe_path;
         path.pop();
-        if path.file_name().map_or(false, |n| n == "bin") {
+        if path.file_name().is_some_and(|n| n == "bin") {
             path.pop();
         }
         return Ok(path);

src/coordinator/coordinator.rs

@@ -25,6 +25,12 @@ use super::execution_context::ExecutionContext;
 
 pub struct Coordinator {}
 
+impl Default for Coordinator {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl Coordinator {
     pub fn new() -> Self {
         Self {}

src/coordinator/execution/executor.rs

@@ -59,6 +59,7 @@ impl Executor {
 }
 
 impl PlanVisitor for Executor {
+    #[allow(clippy::redundant_closure_call)]
     fn visit_create_function(
         &self,
         plan: &CreateFunctionPlan,
@@ -98,6 +99,7 @@ impl PlanVisitor for Executor {
         PlanVisitorResult::Execute(result)
     }
 
+    #[allow(clippy::redundant_closure_call)]
     fn visit_drop_function(
         &self,
         plan: &DropFunctionPlan,
@@ -148,23 +150,25 @@ impl PlanVisitor for Executor {
         PlanVisitorResult::Execute(result)
     }
 
+    #[allow(clippy::redundant_closure_call)]
     fn visit_show_functions(
         &self,
         _plan: &ShowFunctionsPlan,
         _context: &PlanVisitorContext,
     ) -> PlanVisitorResult {
-        let result = (|| -> Result<ExecuteResult, ExecuteError> {
+        let result = {
             let functions = self.task_manager.list_all_functions();
 
             Ok(ExecuteResult::ok_with_data(
                 format!("Found {} task(s)", functions.len()),
                 ShowFunctionsResult::new(functions),
             ))
-        })();
+        };
 
         PlanVisitorResult::Execute(result)
     }
 
+    #[allow(clippy::redundant_closure_call)]
     fn visit_create_python_function(
         &self,
         plan: &CreatePythonFunctionPlan,

src/coordinator/execution_context.rs

@@ -16,12 +16,14 @@ use std::time::{Duration, Instant};
 static EXECUTION_ID_GENERATOR: AtomicU64 = AtomicU64::new(1);
 
 #[derive(Debug)]
+#[allow(dead_code)]
 pub struct ExecutionContext {
     pub execution_id: u64,
     pub start_time: Instant,
     pub timeout: Duration,
 }
 
+#[allow(dead_code)]
 impl ExecutionContext {
     pub fn new() -> Self {
         Self {

src/coordinator/mod.rs

@@ -11,6 +11,7 @@
 // limitations under the License.
 
 mod analyze;
+#[allow(clippy::module_inception)]
 mod coordinator;
 mod dataset;
 mod execution;

src/coordinator/plan/optimizer.rs

@@ -32,10 +32,12 @@ impl LogicalPlanner {
         }
     }
 
+    #[allow(dead_code)]
     pub fn with_optimizers(optimizers: Vec<Box<dyn PlanOptimizer>>) -> Self {
         Self { optimizers }
     }
 
+    #[allow(dead_code)]
     pub fn add_optimizer(&mut self, optimizer: Box<dyn PlanOptimizer>) {
         self.optimizers.push(optimizer);
     }

src/lib.rs

@@ -12,6 +12,8 @@
 
 // Library crate for function-stream
 
+#![allow(dead_code)]
+
 pub mod config;
 pub mod coordinator;
 pub mod logging;

src/main.rs

@@ -10,6 +10,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+#![allow(dead_code)]
+
 mod config;
 mod coordinator;
 mod logging;
@@ -32,10 +34,10 @@ impl ServerHandle {
     pub fn stop(mut self) {
         log::info!("Initiating server shutdown sequence...");
 
-        if let Some(tx) = self.shutdown_tx.take() {
-            if tx.send(()).is_err() {
-                log::warn!("Server shutdown signal failed to send (receiver dropped)");
-            }
+        if let Some(tx) = self.shutdown_tx.take()
+            && tx.send(()).is_err()
+        {
+            log::warn!("Server shutdown signal failed to send (receiver dropped)");
         }
 
         if let Some(handle) = self.join_handle.take() {

src/runtime/buffer_and_event/stream_element/mod.rs

@@ -10,4 +10,5 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+#[allow(clippy::module_inception)]
 mod stream_element;