Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Minify require.js, index.css, and index.html in dist builds #307

Open
3 tasks done
JoshuaKGoldberg opened this issue Aug 19, 2022 · 0 comments
Open
3 tasks done

🛠 Tooling: Minify require.js, index.css, and index.html in dist builds #307

JoshuaKGoldberg opened this issue Aug 19, 2022 · 0 comments
Labels
area: performance Improving the speed of games. area: tooling Builds, infrastructure, packages, and other repository management package: shenanigans-manager status: accepting prs Go ahead and send a pull request to resolve this issue! type: feature Suggested enhancement or new ability.

Comments

@JoshuaKGoldberg
Copy link
Member

Tooling Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

They aren't minified by default in dist/ directories. Every byte counts! ⚡

Maybe the mustache copy command in shenanigans-manager should take in an off-by-default minify arg option, and apply minification to files it knows types of?

Additional Info

ChooseYourFramework does this manually in its deploy script: https://github.com/JoshuaKGoldberg/ChooseYourFramework/blob/0a18b19632b5f321e990748ce8ddb9b5588e005f/fix-index-for-vercel.js#L20
@JoshuaKGoldberg JoshuaKGoldberg added type: feature Suggested enhancement or new ability. status: accepting prs Go ahead and send a pull request to resolve this issue! package: shenanigans-manager area: tooling Builds, infrastructure, packages, and other repository management area: performance Improving the speed of games. labels Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: performance Improving the speed of games. area: tooling Builds, infrastructure, packages, and other repository management package: shenanigans-manager status: accepting prs Go ahead and send a pull request to resolve this issue! type: feature Suggested enhancement or new ability.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg