Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Auto-generate meta previews & loading state with dist/index.html #292

Open
3 tasks done
JoshuaKGoldberg opened this issue Aug 16, 2022 · 0 comments
Open
3 tasks done
Labels
area: tooling Builds, infrastructure, packages, and other repository management status: accepting prs Go ahead and send a pull request to resolve this issue! type: feature Suggested enhancement or new ability.

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Aug 16, 2022

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

I'd like to have JoshuaKGoldberg/ChooseYourFramework#13 be done automatically: so the game's preview image is used as a loading image.

In addition, the default generated dist/index.html file for dist games right now, as managed by shenanigans-manager, doesn't come with many SEO / social media <meta> tags. How about creating a meta value for "shenanigans" settings in the package.json that includes an array of FrameTickr tick waits and/or InputWritr commands to generate a social media preview image?

[
  { "ticks": 10, "type": "tick" },
  { "group": "onkeydown", "key": "left", "type": "input" },
  { "ticks": 10, "type": "tick" },
  { "group": "onkeydown", "key": "down", "type": "input" }
]

I'm wondering if I should switch these packages to a shenanigans.json... #300

Additional Info

No response

@JoshuaKGoldberg JoshuaKGoldberg added type: feature Suggested enhancement or new ability. status: accepting prs Go ahead and send a pull request to resolve this issue! area: tooling Builds, infrastructure, packages, and other repository management labels Aug 16, 2022
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🚀 Feature: Auto-generate meta previews with dist/index.html 🚀 Feature: Auto-generate meta previews & loading state with dist/index.html Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tooling Builds, infrastructure, packages, and other repository management status: accepting prs Go ahead and send a pull request to resolve this issue! type: feature Suggested enhancement or new ability.
Projects
None yet
Development

No branches or pull requests

1 participant