Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserWrappr: Don't create a menu or wait for its sizing when no options are provided #183

Open
JoshuaKGoldberg opened this issue Apr 27, 2018 · 0 comments
Open

UserWrappr: Don't create a menu or wait for its sizing when no options are provided #183

JoshuaKGoldberg opened this issue Apr 27, 2018 · 0 comments
Labels
package: userwrappr type: cleanup Improving code architecture and/or cleanliness.

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Apr 27, 2018 •
edited
Loading

If a UserWrappr is created with menus: [] (ideally it should be | undefined in the types after this change), logic shouldn't attempt to create a container for the menu items or react to it.

Let's do #187 first.
@JoshuaKGoldberg JoshuaKGoldberg changed the title Don't create a menu or wait for its sizing when no options are provided UserWrappr: Don't create a menu or wait for its sizing when no options are provided Jul 11, 2020
@JoshuaKGoldberg JoshuaKGoldberg transferred this issue from FullScreenShenanigans/UserWrappr Jul 11, 2020
@JoshuaKGoldberg JoshuaKGoldberg added package: userwrappr status: accepting prs Go ahead and send a pull request to resolve this issue! type: cleanup Improving code architecture and/or cleanliness. status: blocked Something else should change before this can be addressed. and removed status: accepting prs Go ahead and send a pull request to resolve this issue! labels Jul 11, 2020
@JoshuaKGoldberg JoshuaKGoldberg removed the status: blocked Something else should change before this can be addressed. label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package: userwrappr type: cleanup Improving code architecture and/or cleanliness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg