fix: fix glob expression illegal operations on directories (#1308)

* fix: fix glob expression illegal operations on directories

This fixes the glob regression issues from v5 + parallelizes the async IO operations for faster purge.

## Proposed changes

Fixes an issue that the previously working glob expressions no longer work in v6 and v7. This changes the glob dependency to fast-glob to fix the issue. I also parallelized the async-io operations for faster purge.
Fixes #1266

## Types of changes

What types of changes does your code introduce?
_Put an `x` in the boxes that apply_

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

## Checklist

_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._

- [x] Lint and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation (if appropriate)

## Further comments

* test: add tests for glob

Author: aminya

package-lock.json

@@ -36,7 +36,7 @@
     "test": "jest"
   },
   "dependencies": {
-    "glob": "^11.0.0",
+    "fast-glob": "^3.3.2",
     "plugin-error": "^2.0.0",
     "purgecss": "^7.0.2",
     "through2": "^4.0.1",

packages/gulp-purgecss/package.json

@@ -1,4 +1,4 @@
-import * as glob from "glob";
+import glob from "fast-glob";
 import PluginError from "plugin-error";
 import { PurgeCSS } from "purgecss";
 import * as internal from "stream";

packages/gulp-purgecss/src/index.ts

@@ -1,5 +1,5 @@
 const path = require("path");
-const glob = require("glob");
+const glob = require("fast-glob");
 const MiniCssExtractPlugin = require("mini-css-extract-plugin");
 const {PurgeCSSPlugin} = require("../../../src/");
 

packages/purgecss-webpack-plugin/__tests__/cases/path-and-safelist-functions/webpack.config.js

@@ -1,5 +1,5 @@
 const path = require("path");
-const glob = require("glob");
+const glob = require("fast-glob");
 const MiniCssExtractPlugin = require("mini-css-extract-plugin");
 const { PurgeCSSPlugin } = require("../../../src/");
 

packages/purgecss-webpack-plugin/__tests__/cases/simple-with-exclusion/webpack.config.js

@@ -1,5 +1,5 @@
 const path = require("path");
-const glob = require("glob");
+const glob = require("fast-glob");
 
 const customExtractor = (content) => {
   const res = content.match(/[A-z0-9-:/]+/g) || [];
@@ -19,4 +19,4 @@ module.exports = {
       extensions: ["html", "js"],
     },
   ],
-}
+}

packages/purgecss-webpack-plugin/__tests__/cases/simple/purgecss.config.js

@@ -0,0 +1,24 @@
+import { PurgeCSS } from "../src/";
+import { ROOT_TEST_EXAMPLES } from "./utils";
+
+describe("Glob", () => {
+  it("glob expressions in content/css work", async () => {
+    const resultsPurge = await new PurgeCSS().purge({
+      content: [`${ROOT_TEST_EXAMPLES}comments/**/*.{js,html,json,svg}`],
+      css: [`${ROOT_TEST_EXAMPLES}comments/**/*.css`],
+    });
+
+    expect(resultsPurge[0].file).toBe(
+      `${ROOT_TEST_EXAMPLES}comments/ignore_comment.css`,
+    );
+    expect(resultsPurge[0].css.includes("/* purgecss ignore */")).toBe(false);
+    expect(resultsPurge[0].css.includes("/* purgecss ignore current */")).toBe(
+      false,
+    );
+
+    expect(resultsPurge[1].file).toBe(
+      `${ROOT_TEST_EXAMPLES}comments/ignore_comment_range.css`,
+    );
+    expect(resultsPurge[1].css.includes("h4")).toBe(false);
+  });
+});

packages/purgecss/__tests__/globs.test.ts

@@ -41,7 +41,7 @@
   },
   "dependencies": {
     "commander": "^12.1.0",
-    "glob": "^11.0.0",
+    "fast-glob": "^3.3.2",
     "postcss": "^8.4.47",
     "postcss-selector-parser": "^7.0.0"
   },

packages/purgecss/package.json

@@ -7,7 +7,7 @@
  */
 
 import * as fs from "fs";
-import * as glob from "glob";
+import * as glob from "fast-glob";
 import * as path from "path";
 import * as postcss from "postcss";
 import selectorParser from "postcss-selector-parser";
@@ -451,7 +451,7 @@ class PurgeCSS {
       } catch (err) {
         filesNames.push(
           ...glob.sync(globFile, {
-            nodir: true,
+            onlyFiles: true,
             ignore: this.options.skippedContentGlobs.map((glob) =>
               glob.replace(/^\.\//, ""),
             ),
@@ -645,7 +645,7 @@ class PurgeCSS {
       if (typeof option === "string") {
         processedOptions.push(
           ...glob.sync(option, {
-            nodir: true,
+            onlyFiles: true,
             ignore: this.options.skippedContentGlobs,
           }),
         );