Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forc-client should support alternative signers #6559

Closed
kayagokalp opened this issue Sep 18, 2024 · 0 comments · Fixed by #6578
Closed

forc-client should support alternative signers #6559

kayagokalp opened this issue Sep 18, 2024 · 0 comments · Fixed by #6578
Assignees
@kayagokalp
Labels
code quality enhancement New feature or request forc-client Everything related to the `forc-client` crate. P: critical Should be looked at before anything else

Comments

@kayagokalp
Copy link
Member

Currently the only signer type that forc-client supports is local signing keys. This can be provided in different forms:

  1. manually by exposing the private key as a cli parameter
  2. automatically by the integration with forc-wallet, via dialoguer prompts

That was fine until now but to support more complicated signers, we should be generic over the signer type. Luckily the sdk design is nice in the sense that they have a generic Signer trait that we can use instead of complete WalletUnlocked instances.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kayagokalp kayagokalp

Labels
code quality enhancement New feature or request forc-client Everything related to the `forc-client` crate. P: critical Should be looked at before anything else
Projects
None yet
Milestone
No milestone
1 participant
@kayagokalp