Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we track balance tree and output messages effects at the type system level? #3649

Open
anton-trunov opened this issue Dec 22, 2022 · 0 comments
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen

Comments

@anton-trunov
Copy link
Contributor

PR #3648 introduces new kinds of state effects that are not storage effects, but balance tree effects and output messages effects, but the new effects are not tracked at the level of the type system like the storage effects.

This means the user can get unexpected effect-after-interaction warnings, because this information of is not reflected in the ABI. For instance, the stdlib functions std::token::force_transfer_to_contract, std::token::transfer_to_address, and std::message::send_typed_message all have these new effects but no annotations.

Should we add the new effects to the type system?

@anton-trunov anton-trunov added the compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Development

No branches or pull requests

1 participant