Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port enum instantiation to the declaration engine #3455

Open
tritao opened this issue Nov 28, 2022 · 0 comments
Open

Port enum instantiation to the declaration engine #3455

tritao opened this issue Nov 28, 2022 · 0 comments
Labels
code quality compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged P: medium

Comments

@tritao
Copy link
Contributor

tritao commented Nov 28, 2022

Enum instantiations are still not fully ported to the declaration engine, which makes us end up with duplicate declaration ids for the same enum declaration.

I have tried to fix this in #3310 but ended up hitting some issues which will take more time to investigate and fix.

Since this is currently not blocking anything, I've closed that draft PR and opening this issue for tracking purposes so we can fix it later.
@tritao tritao added compiler General compiler. Should eventually become more specific as the issue is triaged code quality P: medium compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged P: medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tritao