Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track down any missing spans in IR-gen #1262

Open
mohammadfawaz opened this issue Apr 15, 2022 · 2 comments
Open

Track down any missing spans in IR-gen #1262

mohammadfawaz opened this issue Apr 15, 2022 · 2 comments
Labels
bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged P: medium

Comments

@mohammadfawaz
Copy link
Contributor

Similarly to what was done in #1250.. there may be other instances where errors are missing spans.
@mohammadfawaz mohammadfawaz added bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged P: high Should be looked at if there are no critical issues left labels Apr 15, 2022
@mohammadfawaz mohammadfawaz added P: medium and removed P: high Should be looked at if there are no critical issues left labels May 26, 2022
@mohammadfawaz
Copy link
Contributor Author

Under ir_generation, we seem to be using Span::dummy() for empty spans.

@otrho
Copy link
Contributor

otrho commented Sep 7, 2022

...but if there is a better span available which we aren't using we should switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged P: medium
Projects
Fuel Network
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@otrho @vaivaswatha @mohammadfawaz